Specify version of python #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
PeterJCLaw
reviewed
Dec 10, 2017
| title: "Python: A Whirlwind Tour" | ||
| --- | ||
| In this tutorial, we'll introduce the basic concepts of programming, which will be central to the programs that you will run on your robot. There are many different languages in which computers can be programmed, all with their advantages and disadvantages, but we use [Python](https://www.python.org/), specifically version 3. We chose Python because it's easy to learn, but also elegant and powerful. | ||
| In this tutorial, we'll introduce the basic concepts of programming, which will be central to the programs that you will run on your robot. There are many different languages in which computers can be programmed, all with their advantages and disadvantages, but we use [Python](https://www.python.org/). We chose Python because it's easy to learn, but also elegant and powerful. |
There was a problem hiding this comment.
Not sure why you've removed the detail here; having it duplicated feels quite reasonable to me.
If we're worried about things getting out of step we could:
- Refer to it as "Python 3" in most places and only specify the actual version number once
- Define a constant for the version number and then reference that everywhere
There was a problem hiding this comment.
I like the idea of a constant, will add
PeterJCLaw
approved these changes
Dec 12, 2017
| @@ -0,0 +1 @@ | |||
| {{ .Site.Params.pythonVersion }} No newline at end of file | |||
There was a problem hiding this comment.
I'm not sure I see the point of this indirection?
There was a problem hiding this comment.
It's just a little syntactic sugar. Means you can use {{% python_version %}} where it's needed rather than `{{ .Site.Params.pythonVersion }}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify the version of python we're using. The default in stretch is
3.5, so that's what we're using!