refactor: commands

[abeatrix]

Refactor and clean up the existing commands set up, update and add new e2e tests to cover commands and custom commands.

Note: A lot of the files were updated due to attempts to clean up and unify method names, commands, and file names.
For example:

• "cody.action.commands.custom.menu" -> "cody.menu.custom-commands"
• "cody.action.commands.menu" -> "cody.menu.commands"
• "cody.action.commands.exec" -> "cody.action.command"
• "CustomPrompts" -> "CustomCommands"
• file name "CommandRunnerr" -> runner.ts etc

The major change in this PR is moving command to the top level and decouple it from chat and edit. This allows other services to execute a command anywhere through:

• executeCodyCommand: a function that is tied to the execution step in the CommandsController class.
  1. When a command is executed, the request will be sent to the CommandsController
  2. CommandsController will look up the command based on the input, before creating a CommandRunner
  3. Each CommandRunner handles identifying if the command is a chat request or an edit request, then fetch for the relevant context before sending creating the request via executeChat for chat request and executeEdit for edit request respectively.
• 0r via vscode.commands.executeCommand('cody.action.command'): a global command that is connected to executeCodyCommand.
• All the default commands can also be initiated by other services via the vscode commands registered in main.ts.

Summary:

• Context used for custom commands are broken down into individual files inside vscode/src/commands/context
• Default commands are broken down into individual files inside vscode/src/commands/default
• Command controller now handles the sorting and execution at top level
• Slash commands support have been removed from chat
• All the command-handling methods have been removed from the chat panel class
• All the command-context fetching methods have been removed from the chat context provider class

Checklist:

• moved command execution step to top level
• decouple commands from chat
• decouple default commands from custom commands
• remove /ask command from chat
• remove slash commands from chat
• unify command menus
• support codebase as custom command context via addEnhancedContext in cody.action.chat command
• remove command handling from chat panel
• remove get command context from chat
• command runner handles context fetching and categorizing command before sending command prompt with context as either a chat request or inline edit request
• rename files
• replace "custom prompt" with "custom commands"
• clean up command controller
• clean up command provider
• clean up command runner
• clean up command context
• clean up custom command store
• update integration tests for commands
• add e2etests to cover custom command menu
• add e2e tests to cover executing custom command defined in cody.json file
• add e2e tests to cover context defined for a custom command
• add e2e test to cover default command selection context

Test plan

Try executing

• the default chat commands (explain, test, smell)
• default edit command (doc, new test command)
• a custom command

[umpox]

Right click -> Explain code seems to show the full explain prompt, instead of /explain. Is that intended? Also happens with Smell code.

The cog in the Command palette seems to open the custom commands menu. Is that expected? I would have thought it would open VS Code settings 🤔

[umpox]

Took a high level look over the code and it's looking really good. Left some minor comments and a few possible bugs I noticed

[abeatrix]

Right click -> Explain code seems to show the full explain prompt, instead of /explain. Is that intended? Also happens with Smell code.

The cog in the Command palette seems to open the custom commands menu. Is that expected? I would have thought it would open VS Code settings 🤔

@umpox Thanks for the thorough review!

Right click -> Explain code seems to show the full explain prompt, instead of /explain. Is that intended? Also happens with Smell code.

That's intended as part of removing slash commands from chat. This allows user to see the underlaying prompt and tweak it via the new edit buttons as right now, we are disabling the edit buttons on command messages due to this issue.

The cog in the Command palette seems to open the custom commands menu. Is that expected? I would have thought it would open VS Code settings 🤔

Yea that's the current behavior! I do think we can give this menu a makeover in a follow up, but i've updated the menu so that it runs edit command by default instead of ask :D

[umpox]

Thanks! and nice tests 👍

[olafurpg]

@abeatrix the very large addition to the recording file (+15k lines) hints to me that we're adding a lot of unused recordings. The pnpm update-agent-recordings command is supposed to clean up unused recordings but I'm sensing it's not working 100% correctly yet.

You can run this command to reset the commands from origin/main

./agent/scripts/reset-recordings-to-main.sh

I don't see any new LLM requests in the updated tests that could explain why we need 15k new lines to the recording file.

[olafurpg]

FYI I figured out the bug with keepUnusedRecording so that pnpm update-agent-recordings no longer keeps adding new recordings #2926