-
Notifications
You must be signed in to change notification settings - Fork 565
Update Code Insights to use postgres #780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docker-compose/docker-compose.yaml
Outdated
codeinsights-db: | ||
container_name: codeinsights-db | ||
image: 'index.docker.io/sourcegraph/codeinsights-db:insiders@sha256:82fe7f91dbdca1cd397a80f1023d9da4e9c6af103bc36866d800e3a8279eea00' | ||
image: 'index.docker.io/sourcegraph/postgres-12-alpine:135107_2022-03-03_9498a8bd3366@sha256:e26b159dc7c0c47d136886390c899816e669a3c2c1ead689bdad0b610364e45e' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I supposed we will update the image to sourcegraph/codeinsights-db
when https://github.com/sourcegraph/sourcegraph/pull/32616 is merged?
cf82cbb
to
114c482
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
bc2cf4e
to
01d67bb
Compare
Depends on #792 |
This shouldn't be blocked anymore. CI is good now #792 btw, how do I add unreleased release notes for docker-compose? On this page https://github.com/sourcegraph/sourcegraph/blob/main/doc/admin/updates/docker_compose.md, it looks like we've been adding release notes on release day, so no way to do it besides making a note myself? |
This reverts commit 8245bda.
ed71666
to
99c7d8d
Compare
@michaellzc - Unfortunately yes, there's no established process for adding release notes ahead of time. I thought this was mentioned to the release guild at one point but I can't find any record of that. A couple times I've seen people add to that doc with (Unreleased) as a prefix, similar to our Changelog. That might be an ok approach here? |
Update code insights to support running a postgres image. Adds postgres exporter to collect metrics and removes the timescale references.
Depends on https://github.com/sourcegraph/sourcegraph/pull/32616 and https://github.com/sourcegraph/sourcegraph/issues/32077. Part of https://github.com/sourcegraph/sourcegraph/issues/32075.
Checklist
Test plan