Skip to content

Conversation

caugustus-sourcegraph
Copy link
Contributor

@caugustus-sourcegraph caugustus-sourcegraph commented Mar 15, 2022

Update code insights to support running a postgres image. Adds postgres exporter to collect metrics and removes the timescale references.

Depends on https://github.com/sourcegraph/sourcegraph/pull/32616 and https://github.com/sourcegraph/sourcegraph/issues/32077. Part of https://github.com/sourcegraph/sourcegraph/issues/32075.

Checklist

Test plan

  • Base installation of 3.37 + upgrade to this change
  • Base installation of this change

codeinsights-db:
container_name: codeinsights-db
image: 'index.docker.io/sourcegraph/codeinsights-db:insiders@sha256:82fe7f91dbdca1cd397a80f1023d9da4e9c6af103bc36866d800e3a8279eea00'
image: 'index.docker.io/sourcegraph/postgres-12-alpine:135107_2022-03-03_9498a8bd3366@sha256:e26b159dc7c0c47d136886390c899816e669a3c2c1ead689bdad0b610364e45e'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I supposed we will update the image to sourcegraph/codeinsights-db when https://github.com/sourcegraph/sourcegraph/pull/32616 is merged?

Copy link

@CristinaBirkel CristinaBirkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@caugustus-sourcegraph caugustus-sourcegraph force-pushed the caug/deprecate-timescaledb branch from bc2cf4e to 01d67bb Compare April 11, 2022 18:53
@caugustus-sourcegraph
Copy link
Contributor Author

Depends on #792

@michaellzc
Copy link
Member

michaellzc commented Apr 12, 2022

@caugustus-sourcegraph

This shouldn't be blocked anymore. CI is good now #792

btw, how do I add unreleased release notes for docker-compose?

On this page https://github.com/sourcegraph/sourcegraph/blob/main/doc/admin/updates/docker_compose.md, it looks like we've been adding release notes on release day, so no way to do it besides making a note myself?

@caugustus-sourcegraph caugustus-sourcegraph force-pushed the caug/deprecate-timescaledb branch from ed71666 to 99c7d8d Compare April 12, 2022 14:58
@caugustus-sourcegraph
Copy link
Contributor Author

@michaellzc - Unfortunately yes, there's no established process for adding release notes ahead of time. I thought this was mentioned to the release guild at one point but I can't find any record of that.

A couple times I've seen people add to that doc with (Unreleased) as a prefix, similar to our Changelog. That might be an ok approach here?

@caugustus-sourcegraph caugustus-sourcegraph merged commit 0b0ec26 into master Apr 12, 2022
@caugustus-sourcegraph caugustus-sourcegraph deleted the caug/deprecate-timescaledb branch April 12, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants