-
Notifications
You must be signed in to change notification settings - Fork 24
sourcegraph: remove repo-updater deployment #671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer need this service, starting in 6.4. It's fully incorporated into other services now and an empty service doing nothing. Test plan: TBD.
6caaeeb
to
44cc1c2
Compare
eseliger
added a commit
to sourcegraph/docs
that referenced
this pull request
Apr 30, 2025
The service is no longer needed. Corresponding helm chart update: sourcegraph/deploy-sourcegraph-helm#671 Test plan: n/a
michaellzc
approved these changes
Apr 30, 2025
let's also wait for Release's stamp |
eseliger
added a commit
to sourcegraph/deploy-sourcegraph-k8s
that referenced
this pull request
Apr 30, 2025
Sister PR of sourcegraph/deploy-sourcegraph-helm#671. Upgrade info alert is at sourcegraph/docs#1110. The repo-updater service is no longer required starting with Sourcegraph 6.4. Test plan: Repo-updater-less instances have been running for a while now.
6 tasks
DaedalusG
approved these changes
Apr 30, 2025
eseliger
added a commit
to sourcegraph/deploy-sourcegraph-docker
that referenced
this pull request
Apr 30, 2025
Sister PR of sourcegraph/deploy-sourcegraph-helm#671. Upgrade info alert is at sourcegraph/docs#1110. The repo-updater service is no longer required starting with Sourcegraph 6.4. Test plan: Repo-updater-less instances have been running for a while now.
3 tasks
eseliger
added a commit
to sourcegraph/deploy-sourcegraph-docker
that referenced
this pull request
Apr 30, 2025
Sister PR of sourcegraph/deploy-sourcegraph-helm#671. Upgrade info alert is at sourcegraph/docs#1110. The repo-updater service is no longer required starting with Sourcegraph 6.4. Test plan: Repo-updater-less instances have been running for a while now.
eseliger
added a commit
to sourcegraph/deploy-sourcegraph
that referenced
this pull request
Apr 30, 2025
Sister PR of sourcegraph/deploy-sourcegraph-helm#671. Upgrade info alert is at sourcegraph/docs#1110. The repo-updater service is no longer required starting with Sourcegraph 6.4. Test plan: Repo-updater-less instances have been running for a while now.
6 tasks
eseliger
added a commit
to sourcegraph/deploy-sourcegraph-docker-customer-replica-1
that referenced
this pull request
Apr 30, 2025
Sister PR of sourcegraph/deploy-sourcegraph-helm#671. Upgrade info alert is at sourcegraph/docs#1110. The repo-updater service is no longer required starting with Sourcegraph 6.4. Test plan: Repo-updater-less instances have been running for a while now.
3 tasks
eseliger
added a commit
to sourcegraph/deploy-sourcegraph
that referenced
this pull request
Apr 30, 2025
Sister PR of sourcegraph/deploy-sourcegraph-helm#671. Upgrade info alert is at sourcegraph/docs#1110. The repo-updater service is no longer required starting with Sourcegraph 6.4. Test plan: Repo-updater-less instances have been running for a while now. ### Checklist - [ ] [CHANGELOG.md](https://github.com/sourcegraph/sourcegraph/blob/main/CHANGELOG.md) updated - [x] [K8s Upgrade notes updated](https://github.com/sourcegraph/sourcegraph/blob/main/doc/admin/updates/kubernetes.md) - [x] Sister [deploy-sourcegraph-k8s](https://github.com/sourcegraph/deploy-sourcegraph-docker) change: sourcegraph/deploy-sourcegraph-k8s#269 - [x] Sister [deploy-sourcegraph-docker](https://github.com/sourcegraph/deploy-sourcegraph-docker) change: sourcegraph/deploy-sourcegraph-docker#1202 - [ ] All images have a valid tag and SHA256 sum - [x] I acknowledge that [deploy-sourcegraph-k8s](https://github.com/sourcegraph/deploy-sourcegraph-k8s) is now the preferred Kubernetes deployment repository
eseliger
added a commit
to sourcegraph/deploy-sourcegraph-k8s
that referenced
this pull request
Apr 30, 2025
Sister PR of sourcegraph/deploy-sourcegraph-helm#671. Upgrade info alert is at sourcegraph/docs#1110. The repo-updater service is no longer required starting with Sourcegraph 6.4. Test plan: Repo-updater-less instances have been running for a while now. --- ## Checklist - [ ] Update [CHANGELOG.md](https://github.com/sourcegraph/deploy-sourcegraph-k8s/blob/main/CHANGELOG.md) - [x] Update [K8s Upgrade notes](https://github.com/sourcegraph/sourcegraph/blob/main/doc/admin/updates/kubernetes.md) - [x] Kustomiz-specific changes - [x] Update sister repository: [deploy-sourcegraph-helm](https://github.com/sourcegraph/deploy-sourcegraph-helm) - [x] Update sister repository: [deploy-sourcegraph-docker](https://github.com/sourcegraph/deploy-sourcegraph-docker) sourcegraph/deploy-sourcegraph-docker#1202 - [ ] Verify all images have a valid tag and SHA256 sum
eseliger
added a commit
to sourcegraph/docs
that referenced
this pull request
Apr 30, 2025
The service is no longer needed. Corresponding helm chart update: sourcegraph/deploy-sourcegraph-helm#671 Test plan: n/a
eseliger
added a commit
to sourcegraph/deploy-sourcegraph-docker
that referenced
this pull request
May 5, 2025
Sister PR of sourcegraph/deploy-sourcegraph-helm#671. Upgrade info alert is at sourcegraph/docs#1110. The repo-updater service is no longer required starting with Sourcegraph 6.4. Test plan: Repo-updater-less instances have been running for a while now. ### Checklist <!-- Kubernetes and Docker Compose MUST be kept in sync. You should not merge a change here without a corresponding change in the other repository, unless it truly is specific to this repository. If uneeded, add link or explanation of why it is not needed here. --> * [x] Sister [deploy-sourcegraph](https://github.com/sourcegraph/deploy-sourcegraph) change: sourcegraph/deploy-sourcegraph#4468 * [x] Sister [customer-replica](https://github.com/sourcegraph/deploy-sourcegraph-docker-customer-replica-1) change (if necessary, for any changes affecting pure-docker or configuration): sourcegraph/deploy-sourcegraph-docker-customer-replica-1#79 * [ ] All images have a valid tag and SHA256 sum
enriquegh
pushed a commit
that referenced
this pull request
Jul 10, 2025
We no longer need this service, starting in 6.4. It's fully incorporated into other services now and an empty service doing nothing. Test plan: This setup has been running on S2 and Dotcom for a couple of days now. ### Checklist - [ ] Follow the [manual testing process](https://github.com/sourcegraph/deploy-sourcegraph-helm/blob/main/TEST.md) - [x] Update [changelog](https://github.com/sourcegraph/deploy-sourcegraph-helm/blob/main/charts/sourcegraph/CHANGELOG.md) - [x] Update [Kubernetes update doc](https://docs.sourcegraph.com/admin/updates/kubernetes): sourcegraph/docs#1110
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer need this service, starting in 6.4. It's fully incorporated into other services now and an empty service doing nothing.
Test plan: This setup has been running on S2 and Dotcom for a couple of days now.
Checklist