This repository was archived by the owner on Jun 9, 2025. It is now read-only.
Federate lsif-server metrics #548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efritz
changed the title
…eploy-sourcegraph into lsif-prometheus-federation
uwedeportivo
approved these changes
Mar 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This should not be merged until the docker tags have been updated in the deployment, otherwise we will lose metrics for LSIF processes as prometheus is not available in the current containers.
https://github.com/sourcegraph/sourcegraph/pull/8951 introduced a Prometheus server inside the lsif-server containers to scrape and federate metrics from a dynamic number of workers. This introduces a new annotation option
prometheus.io/federatethat enables the/federateendpoint to be scraped for all global metrics.Currently, metrics matching
lsif.*are scraped for all federated endpoints. This list can either grow to contain a non-overlapping prefix set, or we can find a way to supply that argument as an annotation in the config map. For now I think this is a sane approach.