Enable cross-repo navigation. #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olafurpg
force-pushed
the
pkg-info
branch
2 times, most recently
from
d01703e to
e5920f3
Compare
Previously, lsif-java was only able to index a single repositories. It was not possible to navigate between repositories. Now, the emitted LSIF contains `packageInformation` nodes that document how to link LSIF indexes between repositories. Rough summary of the changes in this commit: - New `LsifBuildTool` that we use to index `*-sources.jar` of Java libraries and the JDK sources. - New `ClasspathEntry` class to represent a Maven library. We extract `ClasspathEntry` values from the build via text files in the SemanticDB targetroot. - Miscellaneous small bugfixes while indexing the JDK and Guava. - Fixes sourcegraph#150. - Improved error reporting to debug issues in the `javac` wrapper that we use for Gradle and Maven.
Strum355
reviewed
Apr 16, 2021
Comment on lines
+109
to
+117
| | def artifactType = org.gradle.api.attributes.Attribute.of("artifactType", String.class) | ||
| | def attributeType = "jar" | ||
| | if (config.canBeResolved) { | ||
| | def artifacts = config.incoming.artifactView { view -> | ||
| | view.lenient = true | ||
| | view.attributes { container -> | ||
| | container.attribute(artifactType, attributeType) | ||
| | } | ||
| | }.artifacts |
Contributor
There was a problem hiding this comment.
Really interesting! How did you come across this solution?
Contributor
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
Damn, wish I knew of this many months ago 😆
Strum355
reviewed
Apr 16, 2021
|
|
||
| private <T extends JCTree & JCDiagnostic.DiagnosticPosition> void emitSymbolOccurrence( | ||
| Symbol sym, T posTree, Role role, CompilerRange kind) { | ||
| if (sym == null) return; |
Contributor
There was a problem hiding this comment.
Is this an issue you came across?
Contributor
Author
There was a problem hiding this comment.
Yeah, hit on three NPEs when compiling the JDK
Strum355
approved these changes
Apr 16, 2021
Contributor
Strum355
left a comment
Strum355
left a comment
There was a problem hiding this comment.
🎉 awesome work! A lot to unpack here but LGTM 🙂
48 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, lsif-java was only able to index a single repositories. It
was not possible to navigate between repositories. Now, the emitted LSIF
contains
packageInformationnodes that document how to link LSIFindexes between repositories.
Rough summary of the changes in this commit:
LsifBuildToolthat we use to index*-sources.jarofJava libraries and the JDK sources.
ClasspathEntryclass to represent a Maven library. We extractClasspathEntryvalues from the build via text files in theSemanticDB targetroot.
javacwrapper thatwe use for Gradle and Maven.