Remove abstract/static from interface signature and pretty-print default modifier
#176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strum355
changed the title
abstract from interface signature and pretty-print default modifierabstract/static from interface signature and pretty-print default modifier
48 tasks
olafurpg
approved these changes
Apr 23, 2021
Contributor
olafurpg
left a comment
olafurpg
left a comment
There was a problem hiding this comment.
This is a really nice improvement. LGTM 👍
semanticdb-javac/src/main/java/com/sourcegraph/semanticdb_javac/SemanticdbVisitor.java
Outdated
Show resolved
Hide resolved
Strum355
force-pushed
the
nsc/fix-interface-sigs
branch
from
bf8800d to
a6b6127
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, top-level interface decls included the
abstractmodifier, while nested interfaces includedabstract staticmodifiers. This PR removes those from the pretty-printed signature, while also introducing thedefaultmodifier to the pretty-printing.