Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] remove mentions of ijson and khmer #1140

Merged
merged 3 commits into from
Aug 3, 2020
Merged

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Aug 3, 2020

This updates the docs to remove mentions of these two no-longer-needed packages.

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@ctb ctb mentioned this pull request Aug 3, 2020
@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #1140 into master will increase coverage by 25.16%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1140       +/-   ##
===========================================
+ Coverage   67.86%   93.02%   +25.16%     
===========================================
  Files          24       74       +50     
  Lines        3314     5810     +2496     
===========================================
+ Hits         2249     5405     +3156     
+ Misses       1065      405      -660     
Flag Coverage Δ
#rusttests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/src/lib.rs
src/core/src/errors.rs
src/core/src/sketch/nodegraph.rs
src/core/src/index/search.rs
src/core/src/ffi/utils.rs
src/core/src/index/mod.rs
src/core/tests/minhash.rs
src/core/src/index/sbt/mod.rs
src/core/src/sketch/minhash.rs
src/core/src/ffi/signature.rs
... and 88 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19b32b7...9b4816a. Read the comment docs.

@ctb ctb requested a review from luizirber August 3, 2020 12:52
@luizirber luizirber merged commit 1f27f4f into master Aug 3, 2020
@luizirber luizirber deleted the remove_ijson_and_khmer branch August 3, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants