-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] remove __reduce__ from MinHash class #1144
Conversation
Codecov Report
@@ Coverage Diff @@
## latest #1144 +/- ##
==========================================
+ Coverage 83.89% 92.68% +8.79%
==========================================
Files 98 74 -24
Lines 9126 5810 -3316
==========================================
- Hits 7656 5385 -2271
+ Misses 1470 425 -1045
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should tag this commit as 4.0.0a0
, to show how latest
and stable
diverged.
I like that idea! Plus I think then it shows up in error messages etc. I was really just trying out this PR as an (easily reversed) way to see how messy the whole process would be. So we can be experimental, too. So, I'll take my time to merge and tag it, just to make sure it's all working. Thanks! |
argh! https://github.com/dib-lab/sourmash/releases/tag/v4.0.0a0 is correct. Deleted 4.0.0a0. |
|
* move sourmash._minhash to sourmash.minhash * deprecate max_hash throughout * change MinHash.add(...) to MinHash.add_kmer(...) * remove update and is_molecule_type from MinHash * remove subtract_mins * rename downsample_n to downsample_num * switch to hashes property instead of using get_mins() * replace get_mins(...) with hashes thruout * change deprecated 'compare' usage to 'similarity' in test_jaccard * elminate most of the deprecation warnings in test__minhash by switching compare to similarity * fix remaining tests in test__minhash * fix compat message * restore removed functions, sigh :) * minor upd * add deprecations * use a wrapper object for .hashes and make it read-only * refactor to use downsample(num/scaled= * refactor to use downsample(scaled=...) * return two deleted tests * fixed test that was masked by another test * add explicit check for length of kmer in add_kmer * fix ordering in hash retrieval * fix more tests for py2 <khaaaaaaaaaan> * add 'flatten' method to MinHash * add test for MinHash.flatten * add tests for add and add_kmer * remove nonsense test * test the (now deprecated) get_mins function * test (deprecated) get_hashes * add tests for downsample and is_molecule_type * test moltype properties more explicitly * fix py27 * move translate_codon to module level * put a stub in place of _minhash with a FutureWarning * adjust import req * remove __future__ imports * remove sys.version checks for py 2 * remove requirement for enum34 * remove __reduce__ from MinHash class (#1144) * avoid the DeprecationWarning * update docs: only python 3.7 and 3.8 * remove 2.7 from travis * remove _compat from signature.py * remove _compat from exceptions.py * remove _compat from index and sbt_storage * remove _compat from nodegraph * remove _compat completely * make signature -> sig in CLI using py3 'aliases' * put back assert that didn't work in py2 * Update sourmash/minhash.py Co-authored-by: Luiz Irber <luizirber@users.noreply.github.com> Co-authored-by: Luiz Irber <luizirber@users.noreply.github.com>
Removes
__reduce__
, which was needed for Python 2.7.Fixes #895
NOTE: merge into
latest
, this is a breaking change for 3.x.make test
Did it pass the tests?make coverage
Is the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?