Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Output added hashes up to the Python layer #482

Closed
wants to merge 2 commits into from

Conversation

luizirber
Copy link
Member

Spin-off #477 changes to the C++/Cython layer

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov-io
Copy link

codecov-io commented May 29, 2018

Codecov Report

Merging #482 into master will decrease coverage by 0.09%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #482     +/-   ##
=========================================
- Coverage   90.75%   90.65%   -0.1%     
=========================================
  Files          33       33             
  Lines        5007     5019     +12     
  Branches       36       40      +4     
=========================================
+ Hits         4544     4550      +6     
- Misses        463      466      +3     
- Partials        0        3      +3
Impacted Files Coverage Δ
sourmash/kmer_min_hash.hh 96.62% <75%> (-3.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab67c0b...4a80a28. Read the comment docs.

@luizirber luizirber changed the title Output added hashes up to the Python layer [MRG] Output added hashes up to the Python layer Sep 25, 2018
@luizirber luizirber closed this Jan 4, 2019
@luizirber
Copy link
Member Author

Not used, and will go away with Rust merge anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants