Skip to content

Commit f295be2

Browse files
committed
feat(dialog): update beforeClose prop to allow returning void in Dialog and AlertDialog components
1 parent 10de681 commit f295be2

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

headless/src/components/dialog/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ export interface DialogCloseProps extends PrimitiveProps, /** @vue-ignore */ But
6262
* Called before the dialog is closed. Can be used to prevent the dialog from closing.
6363
* @returns A boolean or a promise that resolves to a boolean. if returns `false`, the dialog will not close.
6464
*/
65-
beforeClose?: () => MaybePromise<boolean>;
65+
beforeClose?: () => MaybePromise<boolean | void>;
6666
}
6767

6868
export interface DialogHeaderProps extends /** @vue-ignore */ HTMLAttributes {}

src/components/alert-dialog/alert-dialog-cancel.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ const { size } = useSizeContext('AlertDialogCancel');
2020
</script>
2121

2222
<template>
23-
<AlertDialogClose as-child>
23+
<AlertDialogClose as-child :before-close="beforeClose">
2424
<slot name="content">
2525
<Button v-bind="forwardedProps" :size="size">
2626
<slot>{{ text }}</slot>

src/components/alert-dialog/types.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,11 @@ export interface AlertDialogCancelProps extends ButtonProps {
1818
* @defaultValue 'Cancel'
1919
*/
2020
text?: string;
21+
/**
22+
* Called before the dialog is closed. Can be used to prevent the dialog from closing.
23+
* @returns A boolean or a promise that resolves to a boolean. if returns `false`, the dialog will not close.
24+
*/
25+
beforeClose?: () => MaybePromise<boolean | void>;
2126
}
2227

2328
export interface AlertDialogActionProps extends ButtonProps {
@@ -31,5 +36,5 @@ export interface AlertDialogActionProps extends ButtonProps {
3136
* Called before the dialog is closed. Can be used to prevent the dialog from closing.
3237
* @returns A boolean or a promise that resolves to a boolean. if returns `false`, the dialog will not close.
3338
*/
34-
beforeClose?: () => MaybePromise<boolean>;
39+
beforeClose?: () => MaybePromise<boolean | void>;
3540
}

0 commit comments

Comments
 (0)