Backports 0.19.1 #33966
Backports 0.19.1 #33966
Commits on Feb 7, 2023
-
-
-
-
Revamp the timer so we always have a designated begin and end. Fix a bug where the phase timer was stopped before the phase started, resulting in incorrect timing reports in timers.json.
-
-
-
uninstall: fix accidental cubic complexity (#34005)
* uninstall: fix accidental cubic complexity Currently spack uninstall runs in worst case cubic time complexity thanks to traversal during traversal during traversal while collecting the specs to be uninstalled. Also brings down the number of error messages printed to something linear in the amount of matching specs instead of quadratic.
-
Fix combine_phase_logs text encoding issues (#34657)
Avoid text decoding and encoding when combining log files, instead combine in binary mode. Also do a buffered copy which is sometimes faster for large log files.
-
PackageBase should not define builder legacy attributes (#33942)
* Add a regression test for 33928 * PackageBase should not set `(build|install)_time_test_callbacks` * Fix audits by preserving the current semantic Co-authored-by: Massimiliano Culpo <massimiliano.culpo@gmail.com>
-
-
Forward lookup of the "run_tests" attribute (#34531)
fixes #34518 Fix an issue due to the MRO chain of the package wrapper during build. Before this PR we were always returning False when the builder object was created before the run_tests method was monkey patched.
-
Use a module-like object to propagate changes in the MRO, when settin…
-
Propagate exceptions from Spack python console (#34547)
fixes #34489 Customize sys.excepthook to raise SystemExit when any unhandled exception reaches the hook.
-
docs: remove monitors and analyzers (#34358)
These experimental features were removed in #31130, but the docs were not. - [x] remove the `spack monitor` and `spack analyze` docs
-
FileCache: Delete the new cache file on exception (#34623)
The code in FileCache for write_transaction attempts to delete the temporary file when an exception occurs under the context by calling shutil.rmtree. However, rmtree only operates on directories while the rest of FileCache uses normal files. This causes an empty file to be written to the cache key when unneeded. Use os.remove instead which operates on normal files. Co-authored-by: Harmen Stoppels <harmenstoppels@gmail.com>
-
spack mirror create takes local paths only (#34992)
spack mirror create cannot work with urls, so it shouldn't promote local paths to file urls.
-
-
buildcache create: make "file exists" less verbose (#35019)
Currently we print 3 lines of "file exist" warning per tarball, this is a bit excessive. Instead, it can be a simple single-line tty.warn message.
-
fix libtool filter for Fujitsu compilers (#34916)
Since legit regular expressions are matched, do not pass string=True to the filter Refs #34897
-
Fix path handling in prefix inspections (#35318)
At least with ZSH, prefix inspections containing `./bin` result in a `$PREFIX/./bin` and result in strange `$PATH` handling. I.e., `module load git` will prepend `/path/to/git/./bin`, `which git` will find the right executable, but `git --version` will print the system one. Normalize the relative path to avoid this behavior. See also #31867.
-
