Fixed issue with spaces in user directory paths causing problems beca… #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use they were not quoted properly. First reported here : https://forum.sparkfun.com/viewtopic.php?f=164&t=50231 Fixes issue sparkfun#19
|
I can confirm that this change worked on my Windows 7 system with Arduino IDE 1.8.9 using an Artemis ATP board. |
|
@EmbeddedMan thanks for the PR. Like @TomWS1 I was concerned about the potential for double sets of quotes, and I had briefly tested adding quotes around the paths but after the '-I' flags. That setup indeed caused problems, just for general information. This all worked fine on my machine too so I am merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…use they were not quoted properly.
First reported here : https://forum.sparkfun.com/viewtopic.php?f=164&t=50231
Fixes issue #19