Allow reading status register #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow reading the status register. This register is important in determining if the value of the ALS and proximity sensor is valid. Not changing the read funcionts since I assume there was a reason that the status register was not checked (performance?).
tcirstea
commented
May 5, 2020
|
Hi @tcirstea ! First of all, thanks so much for your work! SparkFun loves it! I've got a board waiting for me at the office that I need to go pick up to test your PR but it looks good from here. You are absolutely correct in that we don't check status every read for performance sake. Anyways, can I get you to bump the version number in library.properties up to 1.4.3 for the Arduino library manager's sake? |
Bump version
|
Hey @AndyEngland521 any idea when you'll be able to check on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow reading the status register. This register is important in determining if the value of the ALS and proximity sensor is valid.
Not changing the read functions since I assume there was a reason that the status register was not checked (performance?).