Skip to content
This repository was archived by the owner on Jan 28, 2021. It is now read-only.

add gnssFixOk and fix pDOP #70

Closed
wants to merge 1 commit into from
Closed

add gnssFixOk and fix pDOP #70

wants to merge 1 commit into from

Conversation

sslupsky
Copy link

This commit adds gnssFixOk to the global vars.
It also fixes an incorrectly declared data type for pDOP.

@sslupsky
add gnssFixOk and fix pDOP
dba697b 
This commit adds gnssFixOk to teh global vars.
It also fixes an incorrectly declared data type for pDOP.
@PaulZC PaulZC mentioned this pull request Apr 15, 2020
Merged
@PaulZC
Copy link
Collaborator

PaulZC commented Apr 15, 2020

Hi @sslupsky,
Thank you for submitting this PR.
I have merged your PDOP fix - thank you for that: #82.
For gnssFixOK: to do this properly, it needs: its own function called something like getGnssFixOK; its own moduleQueried.gnssFixOK flag; and ideally an example too. If you can submit those in a new PR, I will be happy to merge them.

@PaulZC PaulZC closed this Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sslupsky @PaulZC