First implementation #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfe-SparkFro
requested review from
MadisonC-SparkFun,
SFE-Brudnerd,
edspark and
gigapod
SFE-Brudnerd
suggested changes
Dec 19, 2023
SFE-Brudnerd
left a comment
SFE-Brudnerd
left a comment
There was a problem hiding this comment.
Overall good, needs a few changes.
|
One other thing, you should add an address getter since you have a setter. |
Change constants to Hungarian notation Move _theBus initializer into header Change changeAddress() to take a `const uint8_t&` Remove under read check, since that will be caught by previous check of err Add address getter
edspark
approved these changes
Dec 20, 2023
Contributor
edspark
left a comment
edspark
left a comment
There was a problem hiding this comment.
Nothing to add, this looks great Dryw.
MadisonC-SparkFun
approved these changes
Dec 21, 2023
MadisonC-SparkFun
left a comment
MadisonC-SparkFun
left a comment
There was a problem hiding this comment.
Code looks great! Nice job :)
gigapod
reviewed
Dec 21, 2023
Member
gigapod
left a comment
gigapod
left a comment
There was a problem hiding this comment.
Overall looks great.
What I suggested are easy tweaks - for readability and future understanding.
In computing number of addresses, divide by size of elements Check err against OK constant
Collaborator
Author
|
Thanks all! Library has been published and merged into Arduino's library registry: arduino/library-registry#3782 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.