Examples are in mm, should be cm

[TurnerRussell50]

https://forum.sparkfun.com/viewtopic.php?f=68&t=61409 Has the main issue thread/citations and example # details

[brhoff720]

Thanks for this report and link to the details. in the forum. We'll have an engineer take a closer look.

[edspark]

This was fixed! The millimeters coming out of the registers were being divided by 10.

[bakuhatsu]

The current version of the library still includes the /10 in the code and I had to manually edit this library to get mm output, instead of cm output. Perhaps the changes indicated above were not pushed?

[edspark]

I have the changes pushed here, but upon further inspection I'm seeing the divide by 10 in multiple spots. I'll give it a more thorough look over and update the library as needed. In the mean time can you link which section you had to modify @bakuhatsu?

Thanks!

[bakuhatsu]

Thanks @edspark! I made changes in the file here: src/sfeQwiicXM125.cpp

For each Peak (peaks 0 thought 9) there is a function that looks like this:

int32_t QwDevXM125::getDistancePeak0Distance(uint32_t &peak)
{
    size_t readBytes = 0;
    int32_t retVal = _theBus->readRegister16Region(SFE_XM125_DISTANCE_PEAK0_DISTANCE, (uint8_t*)&peak, 4, readBytes);
    peak = __builtin_bswap32(peak);
    peak = peak/10;
    return retVal;
}

So I removed the line peak = peak/10 since this is taking the data in mm and converting to cm. Since the arduino call returns an int32_t, there is no way to get back to mm unless this line is removed.

After making the change below, the code functioned very well.

int32_t QwDevXM125::getDistancePeak0Distance(uint32_t &peak)
{
    size_t readBytes = 0;
    int32_t retVal = _theBus->readRegister16Region(SFE_XM125_DISTANCE_PEAK0_DISTANCE, (uint8_t*)&peak, 4, readBytes);
    peak = __builtin_bswap32(peak);
    return retVal;
}

Make the same change on the following lines for each of the different peaks.
Lines changed: 377, 386, 395, 404, 413, 422, 431, 440, 449, and 458