Software Development Completed #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added in work done before, toolkit files needed for I2C communication, and the XM125 Acconeer files required.
Added most functions for functionality for the software
Added more functionality to the library, adjusted toolkit files, and added KEYWORD1 and 2 to the keywords.txt file for the arduino library manager
Added correct file structure to README. will update file with correct links once product gets closer to golive
Adjusted the functions to properly handle the inputs and outputs required.
Worked on restructuring the file folder structure. This is now correct, and will be used for the final software. Added structs and defined addresses for the various registers
Need to finish adding to the .cpp file; both presence and distance detection functionality have been added
Function definitions added - need to add register function calls next
Need to finish both files - distance functions/register read and writes, need to finish presence; need to finish arduino_library; added I2C address to Regs file
Most presence functions have been added to the file - need to finish a few error functions for both distance and presence; distance functions have been corrected with call for uint32_t variables
Moved XM125 files
Deleted unneeded files, updated functions unsure of, worked on many errors
No more Arduino IDE errors for the library; added more examples for presence and distance sensing
Made small adjustments for some function names to correct the placement/funcitonality. Fixed keywords.txt and library.prop files for the Arduino IDE to work correctly with this library.
Adjusted keywords and associated files for adjusting begin function. General presence and distance detection begin functions have been deleted and there is only one begin function now
Generic outline for examples created - setup functionality mostly completed. Folder structure, and names have been adjusted for more examples.
Added the correct code to communicate over the I2C bus - need to finish printing and working the examples.
See function setPresenceStart() for correct implementation of this
Need to rewrite basically the entire library - this is being committed for historical purposes
Code has been fixed for the change to function calls - errors resolved, now able to read and write from registers
As per kirks email/request
Added more constants that are required, along with adding more functionality for distance begin
Added more constants, cleaned up code, added new functions; need to cleanup and finish sensing
Busy wait bit is no longer stuck high - able to read presence data :)
Examples need to be completed, but the basic readings is now functional
Updated all the functions for distance and presence sensing to be flipping bytes correctly; switched examples to have presence first and distance second since we will be sending out the product with Presence sensing firmware; general cleanup
Added the new keywords that were needed during testing and to remove magic numbers within the code; changed the example numbers in the arduino file to reflect the naming change
Getting ready for review - all examples are now functional and ready for use
Restructured the examples, added new functionality for the commands; created new functions for beginning and requesting data with only one function call to simplify the examples
The issues with delays have been sorted and is now functional printing out data to the terminal in arduino.
Slight change made to the basic readings for distance sensing
Deleted flipByte function to use a c-standard form. Code has been tested and adjusted accordingly
Added shift values to remove magic numbers
Code is ready for review - magic numbers removed, examples cleaned up, old code removed
Member
|
There are 2800+ files changes, so it really makes the review difficult - any files I should specifally look at? |
Contributor
Author
This review is just a final review before the repo is made public so it would be just a general look-over to make sure it's okay to go live with the product once it's launched. |
This include caused an issue when trying to compile with the NINA-B306. There are no issues with any other boards after deleting.
gigapod
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The XM125 code has now been cleaned up and is ready for review.