Repository navigation
Replies: 1 comment 4 replies
|
It sounds like behaving the way I intended. The alternative is prompting early, but a lot of the point of automatic updates is to reduce/delay prompting and be more silent. A new superseded update resets the impatient timer. Eventually the app will be terminated (whether that is through updating the system or something else). Otherwise the user can perform a manual update check. The current release of Sparkle (behind these changes) does not check for newer updates if an update has already been downloaded, and prompts for an update (e.g. after a week) that could become stale. If a user gets prompted for a new update they know was released a day ago and they opted into automatic installation of updates, they could perceive that as buggy. |
4 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Summary
PR #2928 introduced a regression with automatic update installation:
Updates are not installed and the user is never prompted to install updates if:
AI-generated summary
Each newer release silently replaces the pending update and restarts the one-week countdown.
How it happens
A background check finds a new version, downloads it and prepares it to install when the app quits. That cycle sets
_shouldResetImpatientCheckDate, andSPUUpdatersaves that check's time as the start of the one-week countdown (_updateLastImpatientCheckedDate):Sparkle/Sparkle/SPUUpdater.m
Lines 807 to 811 in 4b20aee
Background checks keep running at the normal interval, which is daily by default, and each one reloads the appcast.
If the appcast has nothing newer, Sparkle resumes the pending update. It shows the popup only once a week has passed since the start date.
If the appcast has a newer version,
didFindValidUpdateWithAppcastItem:drops the pending update and treats the new one as a fresh find. Sparkle downloads it and sets_shouldResetImpatientCheckDateagain, so the week starts over.The popup therefore only appears after a full week with no new release. Otherwise the app stays outdated until the user quits it, logs out or restarts the Mac.
Possible Fix
N/A.
Didn't have time to check and didn't want to paste an unverified AI-generated solution. :)
Version
Most recent commit on
2.xbranch (4b20aee)All reactions