-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement extra keyboard controls #272
Conversation
Codecov Report
@@ Coverage Diff @@
## master #272 +/- ##
==========================================
+ Coverage 91.76% 92.47% +0.70%
==========================================
Files 1 1
Lines 85 93 +8
Branches 24 29 +5
==========================================
+ Hits 78 86 +8
Misses 7 7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update the PR description to describe in a little more detail what these optional keys do? So people don't have to dig through the documentation.
Co-authored-by: Wes Cossick <WesCossick@users.noreply.github.com>
Co-authored-by: Wes Cossick <WesCossick@users.noreply.github.com>
This pull request implements all of the pertinent optional keyboard controls listed on this page: https://www.w3.org/TR/wai-aria-practices/#keyboard-interaction-12
Those include:
Space: It will now activate menu items and close the menu after activation
Printable characters (not including those that have some other function): Will move the focus to the first menu item whose label starts with the corresponding character
Closes #269