Change focus behavior on click #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WesCossick
reviewed
Feb 22, 2023
Co-authored-by: Wes Cossick <WesCossick@users.noreply.github.com>
WesCossick
approved these changes
Feb 22, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request basically inverts the previous default hook behavior on click, making it so it must be specified using the new
focusFirstItemOnClickoption. The new default behavior matches the behavior that used to be enabled by passing thedisableFocusFirstItemOnClickoption, so that option has been removed. I bumped the major version because anyone using that previously existing option would have their code broken by this change, and it also breaks the previously established behavior on click.It should be noted that in the past we thought the default behavior should be the opposite based on the wording of the authoring practices at that time. Since then that version of the authoring practices has been deprecated. In the most recent applicable documentation no behavior is dictated for pointer based interaction. Therefore we can revert to the approach we previously treated as the default while maintaining the option to invert the behavior.