Skip to content

Upgrade root packages #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 29, 2022
Merged

Upgrade root packages #134

merged 11 commits into from
Jul 29, 2022

Conversation

corymharper
Copy link
Contributor

@corymharper corymharper commented Jul 28, 2022

This pull request upgrades every package at the root level to the latest version, and makes any needed changes to deal with breaking changes, including adding new required packages.

Changes that affected us:

  • Various versions of node are no longer supported by packages we use in development, generally speaking only the versions 14 (LTS Maintenance), 16 (LTS), and 18 (Current) are now supported. This required a change to the test runner configuration.
  • JSDOM is no longer included by default as a jest environment and has to be installed separately

@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #134 (c20b1a0) into master (0fe971e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #134   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files          12       12           
  Lines         168      168           
  Branches       46       50    +4     
=======================================
  Hits          165      165           
  Misses          2        2           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c56daa...c20b1a0. Read the comment docs.

WesCossick and others added 2 commits July 28, 2022 12:20
Co-authored-by: Wes Cossick <WesCossick@users.noreply.github.com>
Copy link
Member

@WesCossick WesCossick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a number of places that still use 14.x instead of 16.x in the main.yml file.

@WesCossick
Copy link
Member

WesCossick commented Jul 28, 2022

Actually, can we try using lts/* instead of 16.x and current instead of 18.x, so that we don't have to upgrade that in the future? Be sure to replace all 14.x with lts/* since that was the intent at the time.

Relevant docs: https://github.com/actions/setup-node.

@WesCossick
Copy link
Member

Actually, can we try using lts/* instead of 16.x and current instead of 18.x, so that we don't have to upgrade that in the future? Be sure to replace all 14.x with lts/* since that was the intent at the time.

If this works, we probably want to apply this to our other OSS packages...

@WesCossick
Copy link
Member

I think the build might be failing due to this not being set to true? https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#check-latest-version

@WesCossick WesCossick merged commit b5bef10 into master Jul 29, 2022
@WesCossick WesCossick deleted the upgrade-root-packages branch July 29, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants