This repository was archived by the owner on May 7, 2025. It is now read-only.
Fix reset app button bug #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielduhh
pushed a commit
that referenced
this pull request
Jul 19, 2019
danielduhh
pushed a commit
that referenced
this pull request
Jul 20, 2019
* fix reset app bug (#52) * updates registerServiceWorker, confirms sw-build and sw-template look good, updates package.json to run customized build (#54) * Geolocate callback & reliable fonts (#56) * Send the users location to ga on successful locate Use a more reliable ttf font file * geolocate callback * travis * weird formatting * no longer need to trigger * Revert "updates registerServiceWorker, confirms sw-build and sw-template look good, updates package.json to run customized build (#54)" This reverts commit 3a1158f.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The reset app button was using the old config keys to find the correct zoom level. This updates the reset app function to zoom based on viewport size
UI images:
Please add images for any changes to the UI.
Unit Test Approach:
Describe unit tests being added with that PR.
Test Results:
npm testand did the results pass?Describe other (non-unit) test results here.