This repository was archived by the owner on May 7, 2025. It is now read-only.
updates registerServiceWorker, confirms sw-build and sw-template look… #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… good, updates package.json to run customized build
ccabanero
requested review from
danielduhh and
cbessee
and removed request for
danielduhh
danielduhh
approved these changes
Jul 19, 2019
| "scripts": { | ||
| "start": "react-scripts start", | ||
| "build": "react-scripts build", | ||
| "build-sw": "node ./src/sw-build.js", |
danielduhh
pushed a commit
that referenced
this pull request
Jul 20, 2019
* fix reset app bug (#52) * updates registerServiceWorker, confirms sw-build and sw-template look good, updates package.json to run customized build (#54) * Geolocate callback & reliable fonts (#56) * Send the users location to ga on successful locate Use a more reliable ttf font file * geolocate callback * travis * weird formatting * no longer need to trigger * Revert "updates registerServiceWorker, confirms sw-build and sw-template look good, updates package.json to run customized build (#54)" This reverts commit 3a1158f.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… good, updates package.json to run customized build
Description:
The intention of this pull request is to update such that we can add custom caching rules to this app.
This updates the service worker related files in the following way:
For more details on the steps - see this Wiki ... https://github.com/spatialdev/react-seafood/wiki/Caching-with-Service-Worker
UI images:
No images.
Unit Test Approach:
No Unit tests - this is service worker scaffolding
Test Results:
Deploy the app - use ChromeDev tools to look at the name of the service worker AND the custom cache names Cole added in the sw-template.js file.