Skip to content

ENG-1730 Remove use of imp-tool-bootstrap #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2020
Merged

ENG-1730 Remove use of imp-tool-bootstrap #43

merged 1 commit into from
May 28, 2020

Conversation

Helcaraxan
Copy link
Contributor

No description provided.

@Helcaraxan Helcaraxan requested a review from Mudit-G May 27, 2020 16:36
@Helcaraxan Helcaraxan self-assigned this May 27, 2020
@improbable-prow-robot
Copy link

Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/ENG-1730

@improbable-prow-robot improbable-prow-robot added jira/ENG Indicates a PR has a corresponding JIRA ENG ticket size/XS Denotes a PR that changes 0-14 lines, ignoring generated files. labels May 27, 2020
@Helcaraxan Helcaraxan force-pushed the feature/remove-use-of-imp-tool-bootstrap branch 3 times, most recently from 46ee7df to 4fdde57 Compare May 28, 2020 09:32
@Helcaraxan Helcaraxan force-pushed the feature/remove-use-of-imp-tool-bootstrap branch from 4fdde57 to 6c83881 Compare May 28, 2020 10:42
Mudit-G
Mudit-G reviewed May 28, 2020
View reviewed changes
.toolsharerc
@@ -1,5 +1,3 @@
pinned_tool:
- tool: "imp-ci"
version: "20200206.175502.ed41e47ac7"
- tool: "imp-tool"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this required? IMO, we should keep tools pinned if possible. We've had our CI break in the past because of issues in newer versions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The imp-tool specifically should no longer be pinned. It is baked into agents now. We are in the process of clearing this up by also removing it from toolshare itself to some degree.

Copy link
Contributor

@Mudit-G Mudit-G May 28, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So would an imp-tool upgrade require an agent re-bake?

@Mudit-G
Copy link
Contributor

Mudit-G commented May 28, 2020

From the ticket, I guess

If a Mac agent is very old, it may be missing imp-tool. Rebake this mac, or as a short-term fix cp imp-tool-bootstrap imp-tool

was required for our agents?

@Helcaraxan
Copy link
Contributor Author

No it was not. The issue I was having initially with the PR is that the agents are (obviously) not dockerised (because Mac) and had a lingering toolshare subscription on imp-tool. I have removed it manually.

There is no imp-tool-bootstrap on these agents.

@Helcaraxan Helcaraxan merged commit d27d308 into master May 28, 2020
@improbable-prow-robot improbable-prow-robot deleted the feature/remove-use-of-imp-tool-bootstrap branch May 28, 2020 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Mudit-G Mudit-G Mudit-G approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Helcaraxan Helcaraxan

Labels
jira/ENG Indicates a PR has a corresponding JIRA ENG ticket size/XS Denotes a PR that changes 0-14 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Helcaraxan @improbable-prow-robot @Mudit-G