Skip to content

ENG-1730 Remove use of imp-tool-bootstrap #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2020
Merged

ENG-1730 Remove use of imp-tool-bootstrap #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .toolsharerc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
pinned_tool:
- tool: "imp-ci"
version: "20200206.175502.ed41e47ac7"
- tool: "imp-tool"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this required? IMO, we should keep tools pinned if possible. We've had our CI break in the past because of issues in newer versions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The imp-tool specifically should no longer be pinned. It is baked into agents now. We are in the process of clearing this up by also removing it from toolshare itself to some degree.

Copy link
Contributor

@Mudit-G Mudit-G May 28, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So would an imp-tool upgrade require an agent re-bake?

version: "20200217.173900.11796cb28c"
5 changes: 0 additions & 5 deletions ci/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,6 @@ elif [[ "$(uname -s)" == "Darwin" ]]; then
TOOLBELT_PLATFORM="mac"
SPATIAL_PLATFORM="macos"
SPATIAL_BINARY="spatial"

imp-tool-bootstrap subscribe \
--use_gcs_oidc_auth=false \
--gcs_credentials_type=auto \
--tools=imp-tool
else
TOOLBELT_PLATFORM="win"
SPATIAL_PLATFORM="windows"
Expand Down