Skip to content

Merge preview into master #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 24, 2019
Merged

Merge preview into master #66

merged 2 commits into from
Oct 24, 2019

Conversation

joshuahuburn
Copy link
Contributor

No description provided.

@joshuahuburn joshuahuburn requested a review from mironec October 24, 2019 11:12
@joshuahuburn joshuahuburn self-assigned this Oct 24, 2019
@improbable-prow-robot improbable-prow-robot added jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/XS Denotes a PR that changes 0-14 lines, ignoring generated files. labels Oct 24, 2019
mironec
mironec approved these changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@mironec mironec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were a lot of changes, but after careful consideration, I think this is good to go!

@joshuahuburn joshuahuburn merged commit 73efc02 into master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oblm oblm oblm approved these changes

+1 more reviewer

@mironec mironec mironec approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@joshuahuburn joshuahuburn

Labels

jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/XS Denotes a PR that changes 0-14 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joshuahuburn @mironec @oblm @improbable-prow-robot