Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensible generator #80

Closed
wants to merge 6 commits into from
Closed

Extensible generator #80

wants to merge 6 commits into from

Conversation

Gummibeer
Copy link
Collaborator

@Gummibeer Gummibeer commented May 28, 2019

fixes #25
extends #66
blocked by #133

Ned Zimmerman and others added 5 commits July 17, 2018 19:26
Copy link
Member

@sebastiandedeyne sebastiandedeyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should consider shipping the built extensions by default?

@Gummibeer
Copy link
Collaborator Author

I haven't tried but atm there isn't an easy way to generate the types after installation? The way would be to call php vendor/spatie/schema-org/generate.php [--options]!?
If so I would prefer to add a composer bin file instead of shipping extensions by default.

@Gummibeer
Copy link
Collaborator Author

👊 @sebastiandedeyne ?

@Gummibeer
Copy link
Collaborator Author

Some things that come to mind after a while:

  • should we store all extensions in the same namespace? Or introduce sub-namespaces for each extension? I don't know if schema.org prevents conflicts between Extensions by their own?
  • should we use the vendor folder to store the extension files if called by the user?This would mean that the user should add it as post-install-cmd and post-update-cmd script to prevent loss of vendor files.
  • doing it in composer vendor dir should result in a question/warning by composer because of edited source files!?
  • Is there any reason against having all official/default extensions in the repo? Remove the console command arguments and require dedicated composer packages for any other/custom extensions?

@freekmurze
Copy link
Member

Closing due to inactivity.

@freekmurze freekmurze closed this Jun 24, 2021
@Gummibeer Gummibeer deleted the extensible-generator branch October 5, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make generator extensible for other Schema definitions
3 participants