Skip to content

Pre-compile Patterns of removeCommentChars #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 24, 2025
Merged

Pre-compile Patterns of removeCommentChars #335

merged 3 commits into from
May 24, 2025

Conversation

bact
Copy link
Collaborator

@bact bact commented May 21, 2025 •
edited
Loading

in removeCommentChars:

  • Pre-compile Patterns
  • Ensure no trailing newline
  • Use try-resource to manage the closing of the resource instead of checking it in finally

bact added 3 commits May 21, 2025 16:31
@bact
Pre-compile Patterns fo removeCommentChars
511c5d4 
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact
Check for empty string
5080c78 
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact
Ensure no trailing newline
ba7f83d 
Also use try-resource to manage the closing of the resource instead of checking it in finally

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact bact changed the title Pre-compile Patterns fo removeCommentChars Pre-compile Patterns of removeCommentChars May 21, 2025
goneall
goneall approved these changes May 24, 2025
View reviewed changes
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @bact

@goneall goneall merged commit 3ec6b34 into spdx:master May 24, 2025
1 check passed
@bact bact deleted the compile-regex-rm-comment branch May 24, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goneall goneall goneall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bact @goneall