-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON-LD Serialization doc: Fix relationship type name, Add validation info #802
Conversation
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@rnjudge On line 74 of the README, there is a Can you list which external references should be added? Here's a link to the vocab: https://github.com/spdx/spdx-3-model/blob/main/model/Core/Vocabularies/ExternalRefType.md |
Update the relationship type name Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
I cannot find
From #542, I believe it should be
My apology to tag people from #542 This is related to 3.0.1 Model because I will copy this info, and one related to NamescapeMap in the next paragraph, to the Models and serializations chapter in the spec. So we can use the web page URL https://spdx.github.io/spdx-spec/v3.0.1/serializations/ (and not the repo URL) as a ref inside NamespaceMap description. (see TODOs from 30 July 2024 tech call at #796 (comment) ) -- I have put together as a first try the paragraphs in this PR spdx/spdx-spec#1016 - surely need a lot of edits, please kindly review there. |
Also this one on "XCollection"
What is "XCollection" ? |
I believe it was the placeholder name for SpdxDocument, and the find/replace missed this one. It should be |
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Thank you Joshua. I have replaced XCollection with SpdxDocument here and in the spec doc. |
- Link to one in spdx-spec instead - Remove FIXME and todos Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Because the merge of spdx/spdx-spec#1016, now the Model and serializations chapter in the spec has the content from serialization/README.md's Serialization information section. I will remove that content from the file here, leaving only the link to the spec. |
@bact - could please resolve the merge conflicts - once completed, we can merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but could please resolve the conflict, so we can merge.
To resolve conflicts. Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul
Thank you. @goneall @kestewart conflicts resolved. |
ExternalReference
->ExternalRef
serialization/json_ld/
directory andserialization/json-ld.md
tojsonld
jsonld
inspdx-spec
and license-list-data reposThis is a rework of #766