Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON-LD Serialization doc: Fix relationship type name, Add validation info #802

Merged
merged 14 commits into from
Aug 9, 2024

Conversation

bact
Copy link
Collaborator

@bact bact commented Jul 18, 2024

  • In serialization/README.md
  • In serialization/jsonld.md:
    • Update IRIs to 3.0.1
    • In Validation section, add link to serialization/jsonld/validation.md
    • Add Examples section and add link to serialization/jsonld/examples.md
  • Rename serialization/json_ld/ directory and serialization/json-ld.md to jsonld
  • Make heading capitalization consistent across directory

This is a rework of #766

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@goneall goneall added this to the 3.0.1 milestone Jul 22, 2024
@kestewart kestewart added the serialization Something about the representation of data in bytes label Jul 22, 2024
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

serialization/README.md Outdated Show resolved Hide resolved
@goneall
Copy link
Member

goneall commented Jul 22, 2024

@rnjudge On line 74 of the README, there is a FIXME placeholder for external reference types for security.

Can you list which external references should be added?

Here's a link to the vocab: https://github.com/spdx/spdx-3-model/blob/main/model/Core/Vocabularies/ExternalRefType.md

@zvr zvr removed this from the 3.0.1 milestone Jul 26, 2024
Update the relationship type name

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact bact changed the title JSON-LD Serialization doc: Add info on Validation and Examples, Categorise use cases/examples list JSON-LD Serialization doc: Fix relationship type name, Add validation info Jul 31, 2024
@bact
Copy link
Collaborator Author

bact commented Jul 31, 2024

I cannot find spdxDocumentForArtfact (or spdxDocumentForArtifact) relationship type mentioned here:

A Relationship of type spdxDocumentForArtfact can be used to relate an SpdxDocument to one more serialized for of the SpdxDocument.

From #542, I believe it should be serializedInArtifact:

A Relationship of type serializedInArtifact can be used to relate an SpdxDocument to one more serialized for of the SpdxDocument.

My apology to tag people from #542
@goneall @JPEWdev @sbarnum @zvr can you please confirm this? Thank you.

This is related to 3.0.1 Model because I will copy this info, and one related to NamescapeMap in the next paragraph, to the Models and serializations chapter in the spec. So we can use the web page URL https://spdx.github.io/spdx-spec/v3.0.1/serializations/ (and not the repo URL) as a ref inside NamespaceMap description. (see TODOs from 30 July 2024 tech call at #796 (comment) )

--

I have put together as a first try the paragraphs in this PR spdx/spdx-spec#1016 - surely need a lot of edits, please kindly review there.

@bact
Copy link
Collaborator Author

bact commented Jul 31, 2024

Also this one on "XCollection"

When serializing the physical SpdxDocument, any properties of the logical element which can be represented using native mechanisms in the specific serialization format (e.g. @context prefixes in JSON-LD in place of the namespaceMap) should use these mechanisms and the remaining properties should be serialized within the “XCollection” element itself.

What is "XCollection" ?

@JPEWdev
Copy link
Contributor

JPEWdev commented Jul 31, 2024

Also this one on "XCollection"

When serializing the physical SpdxDocument, any properties of the logical element which can be represented using native mechanisms in the specific serialization format (e.g. @context prefixes in JSON-LD in place of the namespaceMap) should use these mechanisms and the remaining properties should be serialized within the “XCollection” element itself.

What is "XCollection" ?

I believe it was the placeholder name for SpdxDocument, and the find/replace missed this one. It should be SpdxDocument

bact added 3 commits July 31, 2024 20:24
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact
Copy link
Collaborator Author

bact commented Jul 31, 2024

What is "XCollection" ?

I believe it was the placeholder name for SpdxDocument, and the find/replace missed this one. It should be SpdxDocument

Thank you Joshua. I have replaced XCollection with SpdxDocument here and in the spec doc.

- Link to one in spdx-spec instead
- Remove FIXME and todos

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact
Copy link
Collaborator Author

bact commented Aug 8, 2024

Because the merge of spdx/spdx-spec#1016, now the Model and serializations chapter in the spec has the content from serialization/README.md's Serialization information section.

I will remove that content from the file here, leaving only the link to the spec.

@goneall
Copy link
Member

goneall commented Aug 9, 2024

@bact - could please resolve the merge conflicts - once completed, we can merge

Copy link
Contributor

@kestewart kestewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but could please resolve the conflict, so we can merge.

To resolve conflicts.

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul
@bact bact reopened this Aug 9, 2024
@bact
Copy link
Collaborator Author

bact commented Aug 9, 2024

Thank you. @goneall @kestewart conflicts resolved.

@goneall goneall merged commit cf2f4e4 into spdx:main Aug 9, 2024
2 checks passed
@bact bact deleted the update-jsonld-doc branch August 9, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
serialization Something about the representation of data in bytes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants