Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serialization info + NamespaceMap info #1016

Merged

Conversation

bact
Copy link
Collaborator

@bact bact commented Jul 31, 2024

What this PR do?

Background

What this PR still missing?

Use content from https://github.com/spdx/spdx-3-model/blob/main/serialization/README.md and revise to use standard terms like "may", "shall".

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @bact

bact added 2 commits July 31, 2024 20:51
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
docs/serializations.md Outdated Show resolved Hide resolved
Copy link
Member

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good up to question

bact and others added 2 commits August 7, 2024 15:39
Thank you @maxhbr

Co-authored-by: Maximilian Huber <maximilian.huber@tngtech.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
docs/serializations.md Outdated Show resolved Hide resolved
docs/serializations.md Outdated Show resolved Hide resolved
bact and others added 2 commits August 7, 2024 15:48
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Co-Authored-By: Alexios Zavras (zvr) <136705+zvr@users.noreply.github.com>
docs/serializations.md Outdated Show resolved Hide resolved
Co-authored-by: Alexios Zavras (zvr) <zvr+git@zvr.gr>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact bact requested a review from zvr August 8, 2024 16:07
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@zvr zvr merged commit 6a33cc6 into spdx:development/v3.0.1 Aug 8, 2024
3 checks passed
@bact bact deleted the add-NamespaceMap-info-to-Serialization-page branch August 8, 2024 18:22
@bact
Copy link
Collaborator Author

bact commented Aug 8, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants