Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an external-ref of type purl to the example files. #509

Merged
merged 2 commits into from
Jun 20, 2021

Conversation

goneall
Copy link
Member

@goneall goneall commented Apr 27, 2021

Resolves issue #473

Note that the examples already contain a CPE external ref.

Since these example files are machine generated, the order of the elements are somewhat random making the diffs rather useless. You can, however, run these files through compare and viewer or other verification tools to review.

Signed-off-by: Gary O'Neall gary@sourceauditor.com

…473

Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
copyrightText: "Copyright 2008-2010 John Smith"
description: "The GNU C Library defines functions that are specified by the ISO\
\ C standard, as well as additional features specific to POSIX and other derivatives\
\ of the Unix operating system, and extensions specific to GNU systems."
downloadLocation: "http://ftp.gnu.org/gnu/glibc/glibc-ports-2.15.tar.gz"
externalRefs:
- referenceCategory: "SECURITY"
referenceLocator: "cpe:2.3:a:pivotal_software:spring_framework:4.1.0:*:*:*:*:*:*:*"
referenceType: "http://spdx.org/rdf/references/cpe23Type"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to #451, shouldn't this be just "cpe23Type"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar in other places, and also in the JSON.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to #451, shouldn't this be just "cpe23Type"?

@sschuberth I agree - this is a bug in the Java tools or libraries. I added an issue to track: spdx/spdx-java-jackson-store#18

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added a commit to manually fix the reference type.

BTW - the reference type for non-SPDX defined types are still full URI's to make sure they are unique.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI - I'll be offline for a few days and may be a bit slow to responding to any additional review comments

@sschuberth sschuberth requested a review from tsteenbe May 5, 2021 07:43
…es rather than full URI

Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
Copy link
Member

@sschuberth sschuberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only looked at the added references. I did not verify that there are no other changes besides the ordering.

Copy link
Member

@swinslow swinslow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just looked at purl additions, not other changes, but LGTM

@goneall goneall merged commit cd08760 into development/v2.2.1 Jun 20, 2021
@goneall goneall deleted the addpurlexample branch June 20, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants