Fix #102 by using Version method from_str in config.py file. #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavierfigueroav
force-pushed
the
version-fields-issue
branch
from
e95c5de to
1c315e1
Compare
|
We would need some tests for this! |
xavierfigueroav
force-pushed
the
version-fields-issue
branch
from
1c315e1 to
28e5d05
Compare
|
|
But this needs to be rebased too |
Signed-off-by: Xavier Figueroa <xavierfigueroav@gmail.com>
Signed-off-by: Xavier Figueroa <xavierfigueroav@gmail.com>
xavierfigueroav
force-pushed
the
version-fields-issue
branch
from
28e5d05 to
82ccee8
Compare
…ion.json. Add tests for exceptions list in config.py. Signed-off-by: Xavier Figueroa <xavierfigueroav@gmail.com>
Great!
@pombredanne It is now rebased! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #102
This PR modifies config.py file to use the method
from_strinVersioninstead of creating the object directly with string values.Signed-off-by: Xavier Figueroa xavierfigueroav@gmail.com