Skip to content

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Oct 31, 2022

Signed-off-by: John Vandenberg jayvdb@gmail.com

nicoweidner
nicoweidner previously approved these changes Nov 2, 2022
Copy link
Collaborator

@nicoweidner nicoweidner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, much appreciated!

@@ -1248,13 +1248,13 @@ def add_file_dep(self, doc, value):

def set_file_atrificat_of_project(self, doc, symbol, value):
"""
Set a file name, uri or home artificat.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The artificat strikes again!
(Sorry for the nonsensical comment, but I find this typo hilarious)

@nicoweidner
Copy link
Collaborator

nicoweidner commented Nov 2, 2022

Looks like Appveyor is broken for some reason :-/. @licquia @goneall @pombredanne Can any of you do something about this? Sorry about the triple ping, but this currently blocks all PRs, and as far as I can tell, I am lacking permissions to check out what's going on there. The only workaround I can think of is deleting appveyor.yml, but that's not really a solution...

@goneall
Copy link
Member

goneall commented Nov 2, 2022

Looks like Appveyor is broken for some reason :-/. @licquia @goneall @pombredanne Can any of you do something about this? Sorry about the triple ping, but this currently blocks all PRs, and as far as I can tell, I am lacking permissions to check out what's going on there. The only workaround I can think of is deleting appveyor.yml, but that's not really a solution...

I'm afraid I don't know much about this myself - I don't use Appveyor and do not have a login or permissions to check what's wrong.

@pombredanne - is this something you can help with?

BTW - I noticed this repo is using Travis. For many of the other SPDX repos we moved to Github actions - something we may want to consider here.

@nicoweidner
Copy link
Collaborator

@jayvdb I can merge this after a rebase

Signed-off-by: John Vandenberg <jayvdb@gmail.com>
@nicoweidner nicoweidner merged commit 30c1f4e into spdx:main Nov 3, 2022
@jayvdb jayvdb deleted the spelling branch November 3, 2022 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants