[issue-328] jsonyamlxml: fix parsing of file copyright text #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spdx/parsers/jsonyamlxmlbuilders.py
Outdated
| @@ -205,6 +205,22 @@ def set_file_type(self, doc, type_value): | |||
|
|
|||
| return super(FileBuilder, self).set_file_type(doc, f"namespace#fileType_{type_value.lower()}") | |||
|
|
|||
| def set_file_copyright(self, doc, text): | |||
| """ | |||
| Raise OrderError if no package or file defined. | |||
There was a problem hiding this comment.
Luckily, packages are out of the equation now :)
spdx/parsers/jsonyamlxmlbuilders.py
Outdated
Comment on lines
218
to
214
| else: | ||
| raise CardinalityError("File::CopyRight") | ||
| else: | ||
| raise OrderError("File::CopyRight") |
There was a problem hiding this comment.
early return could be applied
meretp
force-pushed
the
fix_jsonyamlxml_parser
branch
from
f8591d2 to
a21fcda
Compare
armintaenzertng
previously approved these changes
Nov 29, 2022
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
meretp
force-pushed
the
fix_jsonyamlxml_parser
branch
from
6cd9f65 to
47b4914
Compare
armintaenzertng
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #328
Signed-off-by: Meret Behrens meret.behrens@tngtech.com