Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[issue-540] change DESCRIBES validation #577

Merged
merged 1 commit into from Apr 13, 2023
Merged

[issue-540] change DESCRIBES validation #577

merged 1 commit into from Apr 13, 2023

Conversation

armintaenzertng
Copy link
Collaborator

The new logic is now:
A DESCRIBES relationship is not mandatory if there is only a single SPDX element present which is a package.

meretp
meretp approved these changes Apr 12, 2023
View reviewed changes
Copy link
Collaborator

@meretp meretp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I stumbled a bit over the wording of the validation message since negations of cardinalities are a bit tricky but I don't have a better suggestion.

@armintaenzertng
[issue-540] change validation: allow no DESCRIBES relationship if the…
73e81a5 
…re is a single package only

Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
@armintaenzertng armintaenzertng linked an issue Apr 13, 2023 that may be closed by this pull request
Change validation to allow documents without DESCRIBES relationships #540
Closed
@armintaenzertng armintaenzertng merged commit a9ad3f6 into spdx:main Apr 13, 2023
32 checks passed
@armintaenzertng armintaenzertng deleted the allowDocsWithoutDescribes branch April 13, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meretp meretp meretp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change validation to allow documents without DESCRIBES relationships
2 participants
@armintaenzertng @meretp