Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: export view types #1104

Merged
merged 1 commit into from
Apr 27, 2024
Merged

chore: export view types #1104

merged 1 commit into from
Apr 27, 2024

Conversation

Fdawgs
Copy link
Contributor

@Fdawgs Fdawgs commented Apr 25, 2024

I was previously able to declare a variable's type in VS Code using the following:

/** @type {import('compromise/types/view/three').default} */`
const test = nlp.view;

console.log(test.sentences());

This would allow Intellisense to kick in, so if i hovered over test.sentences() i'd get the following:
image

However it seems the latest minor version of TypeScript which shipped with VS Code has removed that.
This PR updates package.json to explicitly export the view types, so that the type can continue to be declared like so:

/** @type {import('compromise/view/three').default} */
const test = nlp.view

@spencermountain
Copy link
Owner

thank you!
sorry, not sure what's happened with the github script.
I owe ya a drink, Frazer.

@spencermountain spencermountain merged commit 3e7b807 into spencermountain:master Apr 27, 2024
0 of 6 checks passed
@Fdawgs Fdawgs deleted the patch-1 branch April 28, 2024 08:15
@spencermountain spencermountain mentioned this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants