Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bash-v2): activeHelp length check syntax #1762

Merged
merged 1 commit into from Aug 13, 2022

Conversation

scop
Copy link
Contributor

@scop scop commented Jul 22, 2022

$ set -u
$ foo=()
$ echo ${#foo}
bash: foo: unbound variable
echo ${#foo[*]}
0

```shell
$ set -u
$ foo=()
$ echo ${#foo}
bash: foo: unbound variable
echo ${#foo[*]}
0
```
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines label Jul 22, 2022
@scop
Copy link
Contributor Author

scop commented Jul 22, 2022

#1702 requires a rebase after this is in, will take care of it.

@marckhouzam
Copy link
Collaborator

Nice catch! Thanks @scop.
I'll run some tests on this next week and get it merged.
I assume this was the only unbound variable problem with ActiveHelp?

@scop
Copy link
Contributor Author

scop commented Jul 22, 2022

The only one I happened to hit with my normal usage patterns, yes. I didn't analyze beyond that.

Copy link
Collaborator

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this with the cobra-cli also using its ActiveHelp patch, and I can see the problem when I do set -u in bash, but with the patch, all is well.

Thanks @scop

@marckhouzam marckhouzam merged commit f911c0b into spf13:main Aug 13, 2022
15 checks passed
@marckhouzam marckhouzam added this to the 1.6.0 milestone Aug 13, 2022
@marckhouzam marckhouzam added kind/bug A bug in cobra; unintended behavior area/shell-completion All shell completions labels Aug 13, 2022
@scop scop deleted the fix/activehelp-length-check branch August 19, 2022 15:41
jimschubert added a commit to jimschubert/cobra that referenced this pull request Oct 3, 2022
* main: (39 commits)
  Add '--version' flag to Help output (spf13#1707)
  Expose ValidateRequiredFlags and ValidateFlagGroups (spf13#1760)
  Document option to hide the default completion cmd (spf13#1779)
  ci: add workflow_dispatch (spf13#1387)
  add missing license headers (spf13#1809)
  ci: use action/setup-go's cache (spf13#1783)
  Adjustments to documentation (spf13#1656)
  Rename Powershell completion tests (spf13#1803)
  Support for case-insensitive command names (spf13#1802)
  Deprecate ExactValidArgs() and test combinations of args validators (spf13#1643)
  Use correct stale action `exempt-` yaml keys (spf13#1800)
  With go 1.18, we must use go install for a binary (spf13#1726)
  Clarify SetContext documentation (spf13#1748)
  ci: test on Golang 1.19 (spf13#1782)
  fix: show flags that shadow parent persistent flag in child help (spf13#1776)
  Update gopkg.in/yaml.v2 to gopkg.in/yaml.v3 (spf13#1766)
  fix(bash-v2): activeHelp length check syntax (spf13#1762)
  fix: correct command path in see_also for YAML doc (spf13#1771)
  build(deps): bump github.com/inconshreveable/mousetrap (spf13#1774)
  docs: add zitadel to the list (spf13#1772)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/shell-completion All shell completions kind/bug A bug in cobra; unintended behavior size/XS Denotes a PR that changes 0-9 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants