fix(bash-v2): activeHelp length check syntax #1762

scop · 2022-07-22T14:28:11Z

$ set -u
$ foo=()
$ echo ${#foo}
bash: foo: unbound variable
echo ${#foo[*]}
0

```shell $ set -u $ foo=() $ echo ${#foo} bash: foo: unbound variable echo ${#foo[*]} 0 ```

scop · 2022-07-22T14:29:24Z

#1702 requires a rebase after this is in, will take care of it.

marckhouzam · 2022-07-22T14:34:54Z

Nice catch! Thanks @scop.
I'll run some tests on this next week and get it merged.
I assume this was the only unbound variable problem with ActiveHelp?

scop · 2022-07-22T19:34:47Z

The only one I happened to hit with my normal usage patterns, yes. I didn't analyze beyond that.

marckhouzam

I've tested this with the cobra-cli also using its ActiveHelp patch, and I can see the problem when I do set -u in bash, but with the patch, all is well.

Thanks @scop

* main: (39 commits) Add '--version' flag to Help output (spf13#1707) Expose ValidateRequiredFlags and ValidateFlagGroups (spf13#1760) Document option to hide the default completion cmd (spf13#1779) ci: add workflow_dispatch (spf13#1387) add missing license headers (spf13#1809) ci: use action/setup-go's cache (spf13#1783) Adjustments to documentation (spf13#1656) Rename Powershell completion tests (spf13#1803) Support for case-insensitive command names (spf13#1802) Deprecate ExactValidArgs() and test combinations of args validators (spf13#1643) Use correct stale action `exempt-` yaml keys (spf13#1800) With go 1.18, we must use go install for a binary (spf13#1726) Clarify SetContext documentation (spf13#1748) ci: test on Golang 1.19 (spf13#1782) fix: show flags that shadow parent persistent flag in child help (spf13#1776) Update gopkg.in/yaml.v2 to gopkg.in/yaml.v3 (spf13#1766) fix(bash-v2): activeHelp length check syntax (spf13#1762) fix: correct command path in see_also for YAML doc (spf13#1771) build(deps): bump github.com/inconshreveable/mousetrap (spf13#1774) docs: add zitadel to the list (spf13#1772) ...

fix(bash-v2): activeHelp length check syntax

53c6d8a

```shell $ set -u $ foo=() $ echo ${#foo} bash: foo: unbound variable echo ${#foo[*]} 0 ```

github-actions bot added the size/XS Denotes a PR that changes 0-9 lines label Jul 22, 2022

marckhouzam approved these changes Aug 13, 2022

View changes

marckhouzam merged commit f911c0b into spf13:main Aug 13, 2022
15 checks passed

marckhouzam added this to the 1.6.0 milestone Aug 13, 2022

marckhouzam added kind/bug A bug in cobra; unintended behavior area/shell-completion All shell completions labels Aug 13, 2022

scop deleted the fix/activehelp-length-check branch August 19, 2022 15:41

umarcor mentioned this pull request Aug 21, 2022

Summer 2022 release 🌞 #1736

Closed

fix(bash-v2): activeHelp length check syntax #1762

fix(bash-v2): activeHelp length check syntax #1762

scop commented Jul 22, 2022

scop commented Jul 22, 2022

marckhouzam commented Jul 22, 2022

scop commented Jul 22, 2022

marckhouzam left a comment

fix(bash-v2): activeHelp length check syntax #1762

fix(bash-v2): activeHelp length check syntax #1762

Conversation

scop commented Jul 22, 2022

scop commented Jul 22, 2022

marckhouzam commented Jul 22, 2022

scop commented Jul 22, 2022

marckhouzam left a comment

Choose a reason for hiding this comment