Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use action/setup-go's cache #1783

Merged
merged 2 commits into from Sep 14, 2022
Merged

ci: use action/setup-go's cache #1783

merged 2 commits into from Sep 14, 2022

Conversation

umarcor
Copy link
Contributor

@umarcor umarcor commented Aug 21, 2022

Since v3, Action setup-go has built-in support for caching modules. See https://github.com/actions/setup-go#caching-dependency-files-and-build-outputs.

Ref: #1660

@github-actions github-actions bot added area/github For changes to Github specific things not shipped in the library size/XS Denotes a PR that changes 0-9 lines labels Aug 21, 2022
@github-actions github-actions bot added size/S Denotes a PR that chanes 10-24 lines and removed size/XS Denotes a PR that changes 0-9 lines labels Aug 21, 2022
.github/workflows/test.yml Show resolved Hide resolved
.github/workflows/test.yml Show resolved Hide resolved
.github/workflows/test.yml Show resolved Hide resolved
Copy link

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I've seen the caching really speed things up in other projects.

.github/workflows/test.yml Show resolved Hide resolved
jpmcb
jpmcb approved these changes Sep 11, 2022
@jpmcb jpmcb added the lgtm Denotes "looks good to me" from maintainers and signals other collaboratores that a PR is ready label Sep 11, 2022
Copy link
Collaborator

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable, but I am not well versed in GH actions.
I leave it up to you guys.

@jpmcb jpmcb mentioned this pull request Sep 14, 2022
jpmcb
jpmcb approved these changes Sep 14, 2022
@jpmcb jpmcb merged commit 4065a33 into spf13:main Sep 14, 2022
15 checks passed
@umarcor umarcor deleted the umarcor/ci/cache branch September 14, 2022 22:44
@marckhouzam marckhouzam added this to the 1.6.0 milestone Sep 15, 2022
jimschubert added a commit to jimschubert/cobra that referenced this pull request Oct 3, 2022
* main: (39 commits)
  Add '--version' flag to Help output (spf13#1707)
  Expose ValidateRequiredFlags and ValidateFlagGroups (spf13#1760)
  Document option to hide the default completion cmd (spf13#1779)
  ci: add workflow_dispatch (spf13#1387)
  add missing license headers (spf13#1809)
  ci: use action/setup-go's cache (spf13#1783)
  Adjustments to documentation (spf13#1656)
  Rename Powershell completion tests (spf13#1803)
  Support for case-insensitive command names (spf13#1802)
  Deprecate ExactValidArgs() and test combinations of args validators (spf13#1643)
  Use correct stale action `exempt-` yaml keys (spf13#1800)
  With go 1.18, we must use go install for a binary (spf13#1726)
  Clarify SetContext documentation (spf13#1748)
  ci: test on Golang 1.19 (spf13#1782)
  fix: show flags that shadow parent persistent flag in child help (spf13#1776)
  Update gopkg.in/yaml.v2 to gopkg.in/yaml.v3 (spf13#1766)
  fix(bash-v2): activeHelp length check syntax (spf13#1762)
  fix: correct command path in see_also for YAML doc (spf13#1771)
  build(deps): bump github.com/inconshreveable/mousetrap (spf13#1774)
  docs: add zitadel to the list (spf13#1772)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/github For changes to Github specific things not shipped in the library lgtm Denotes "looks good to me" from maintainers and signals other collaboratores that a PR is ready size/S Denotes a PR that chanes 10-24 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants