Frontend Dynamic env variables update bug patch #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mamy-CS
commented
Jun 1, 2023
mamy-CS
commented
- Because of env.js and env.ts discrepancy env variables assigned at runtime in a container were not being injected into the application
- This pr solves the above issue
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net> Co-authored-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net>
Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net> Co-authored-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net>
* break into two builds and reduce fe image to 781mb Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MacBook-Pro-2.local> * moving to production image size reduced to 178mb Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MacBook-Pro-2.local> * dynamically changing container port Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net> * adding docker compose Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net> --------- Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MacBook-Pro-2.local> Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net> Co-authored-by: Mohammed Abdi <moabdi@Mohammeds-MacBook-Pro-2.local> Co-authored-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net>
* adding path module and a fallback Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net> * updating node version Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net> --------- Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net> Co-authored-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net>
* adding path module and a fallback Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net> * updating node version Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net> * updating node master build Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net> * progress Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net> * downgrading Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net> * downgrading Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net> --------- Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net> Co-authored-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net>
* break into two builds and reduce fe image to 781mb Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MacBook-Pro-2.local> * moving to production image size reduced to 178mb Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MacBook-Pro-2.local> * dynamically changing container port Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net> * adding docker compose Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net> * adding env file Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net> --------- Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MacBook-Pro-2.local> Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net> Co-authored-by: Mohammed Abdi <moabdi@Mohammeds-MacBook-Pro-2.local> Co-authored-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net> Co-authored-by: Mariusz Sabath <mrsabath@gmail.com>
Signed-off-by: Mohammed Abdi <mohammma@usc.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.