feat(titus): Lookup server group names when converting TitusDeployDescription #4654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robzienert
approved these changes
Jun 4, 2020
...lix/spinnaker/clouddriver/titus/deploy/converters/TitusDeployAtomicOperationConverter.groovy
Show resolved
Hide resolved
ajordens
approved these changes
Jun 5, 2020
jonsie
force-pushed
the
remove-authorization-resource-nameable
branch
from
b54e1bf
to
1f0bf10
Compare
…cription -Additionally, removes requiresAuthorization from `ResourcesNameable` and removes `BasicAmazonDeployDescription` implementation of `ResourcesNameable`. We will instead be requiring authorization on these resources via an implementation of `AllowedAccountsValidator` which runs prior to `DescriptionAuthorizer`.
jonsie
force-pushed
the
remove-authorization-resource-nameable
branch
from
1f0bf10
to
271e8be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Additionally, removes requiresAuthorization from
ResourcesNameableand removesBasicAmazonDeployDescriptionimplementation ofResourcesNameable. We will instead be requiring authorization on these resources via an implementation ofAllowedAccountsValidatorwhich runs prior toDescriptionAuthorizer.