fix(dynamicAccounts): Included java files in source set #5090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 10, 2020 12:12
Proves that the build of clouddriver-configserver doesn't include java source files
german-muzquiz
added
the
backport-candidate
|
cc @dogonthehorizon backport candidate for |
cfieber
approved these changes
Nov 10, 2020
|
@Mergifyio backport release-1.23.x |
dogonthehorizon
removed
the
backport-candidate
mergify bot
pushed a commit
that referenced
this pull request
Nov 16, 2020
* fix(dynamicAccounts): Compilation error for testing Proves that the build of clouddriver-configserver doesn't include java source files * fix(dynamicAccounts): Included java files in source set * fix(dynamicAccounts): Removed compilation error (cherry picked from commit c0c90db)
|
Command
|
mergify bot
added a commit
that referenced
this pull request
Nov 16, 2020
* fix(dynamicAccounts): Compilation error for testing Proves that the build of clouddriver-configserver doesn't include java source files * fix(dynamicAccounts): Included java files in source set * fix(dynamicAccounts): Removed compilation error (cherry picked from commit c0c90db) Co-authored-by: German Muzquiz <35276119+german-muzquiz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module
clouddriver-configserveris misconfigured. It doesn't detect the source files insrc/main/java. As a result, the jar fileclouddriver-configserver.jarproduced in builds lacks any java classes.This can be easily verified if whithout this fix, you introduce a compilation error in
CloudConfigRefreshConfigand run./gradlew build -x test, as it builds successfully.Closes spinnaker/spinnaker#6128