fix(lambda): refactor and fix handle and ondemand caching for lambda #5437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachsmith1
changed the title
jorgebee65
approved these changes
Jul 28, 2021
zachsmith1
added
the
backport-candidate
|
@Mergifyio backport release-1.26.x release-1.25.x release-1.24.x |
mergify bot
pushed a commit
that referenced
this pull request
Jul 28, 2021
…5437) * fix(lambda): initialize evictions map with a mutable map * fix(lambda): add evictions to the lambda cache interval * fix(lambda): add evictions to the lambda cache interval * fix(lambda): add evictions to the lambda cache interval * fix(lambda): refactor and fix handle and ondemand caching for lambda * fix(lambda): implement applicationNameable for app authz * fix(lambda): implement applicationNameable for app authz * fix(lambda): fix failed test by moving appName to abstract class * fix(lambda): fix failed test by moving appName to abstract class * fix(lambda): fix failed test by moving appName to abstract class * fix(lambda): return empty list if appName is null/empty Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit a616975)
mergify bot
pushed a commit
that referenced
this pull request
Jul 28, 2021
…5437) * fix(lambda): initialize evictions map with a mutable map * fix(lambda): add evictions to the lambda cache interval * fix(lambda): add evictions to the lambda cache interval * fix(lambda): add evictions to the lambda cache interval * fix(lambda): refactor and fix handle and ondemand caching for lambda * fix(lambda): implement applicationNameable for app authz * fix(lambda): implement applicationNameable for app authz * fix(lambda): fix failed test by moving appName to abstract class * fix(lambda): fix failed test by moving appName to abstract class * fix(lambda): fix failed test by moving appName to abstract class * fix(lambda): return empty list if appName is null/empty Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit a616975)
mergify bot
pushed a commit
that referenced
this pull request
Jul 28, 2021
…5437) * fix(lambda): initialize evictions map with a mutable map * fix(lambda): add evictions to the lambda cache interval * fix(lambda): add evictions to the lambda cache interval * fix(lambda): add evictions to the lambda cache interval * fix(lambda): refactor and fix handle and ondemand caching for lambda * fix(lambda): implement applicationNameable for app authz * fix(lambda): implement applicationNameable for app authz * fix(lambda): fix failed test by moving appName to abstract class * fix(lambda): fix failed test by moving appName to abstract class * fix(lambda): fix failed test by moving appName to abstract class * fix(lambda): return empty list if appName is null/empty Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit a616975)
|
Command
|
link108
removed
the
backport-candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lambda caching agent wasn't handling evictions correctly so this adds the implementation. It's doing a very simple comparison of the keys in the db vs the new keys and adding eviction keys to the DefaultCacheResult.
We also added a fix for loadData so that it properly stores data and reconciles ondemand data.
We also added a fix for onDemand caching because it wasn't fully implemented. It now stores data correctly in the onDemand table and the regular interval will process it like most caching agents today.
We also implemented pendingOnDemandRequests so that a caller can see if their ondemand data has been processed.