fix(appengine): allow sequence to be suppressed in servergroup names #6667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
ezimanyi
approved these changes
Mar 11, 2019
|
@spinnakerbot cherry-pick 1.12 |
|
Cherry pick successful: #6671 |
ghost
pushed a commit
that referenced
this pull request
Mar 12, 2019
ghost
mentioned this pull request
|
Tested and working. However I'd like to know how much work is there to support a user-supplied version string instead of hardcoding it to the application name? |
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Jun 5, 2019
e2b4d8e refactor(*): remove unused local storage caches (spinnaker#6665) 49affe7 fix(appengine): allow sequence to be suppressed in servergroup names (spinnaker#6667) 7d5fc34 chore(prettier): Just Use Prettier™ (spinnaker#6600) 5cf6c79 chore(prettier): Just Use Prettier™ 3ffa4fb chore(angularjs): Do not use .component('foo', new Foo()) cc52bee chore(angularjs): Remove all 'ngInject'; in favor of explicit DI annotation b6bab1e chore(prettier): Just Use Prettier™ f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points e1b6663 fix(eslint): Fix eslint warnings for @typescript-eslint/no-use-before-define ddbe208 fix(eslint): Fix eslint warnings for no-useless-escape a35088a chore(webpack): Switch to TerserPlugin. Split bundles into ~5mb chunks 5c49dd2 chore(typescript): Switch module from 'commonjs' to 'esnext' to emit raw dynamic 'import()' 0451046 chore(package): Add .npmignore to all packages 6f608a0 fix(*): Remove all self closing tags in AngularJS templates Reference: angular/angular.js#1953 (comment) 93f1209 fix(appengine/google/kubernetes): change logo background colors to official brand colors (spinnaker#6347) 86baac9 refactor(*): use mask-image CSS for cloud provider logos (spinnaker#6280) 8cef885 fix(appengine): move artifact account dropdown below radio buttons (spinnaker#6255) 6b8188b chore(*): Add core alias to module tsconfigs c190c41 fix(appengine): the selectedProvider is received as null when Create Server Group btn clicked (spinnaker#5908) 351d4fb feat(appengine): unflag container image url deployments (spinnaker#5894) 0a6d3f9 feat(provider/appengine): enable artifacts as config files (spinnaker#5888) bdca8aa feat(appengine): move config template into html file (spinnaker#5870)
christopherthielen
added a commit
that referenced
this pull request
Jun 5, 2019
e2b4d8e refactor(*): remove unused local storage caches (#6665) 49affe7 fix(appengine): allow sequence to be suppressed in servergroup names (#6667) 7d5fc34 chore(prettier): Just Use Prettier™ (#6600) 5cf6c79 chore(prettier): Just Use Prettier™ 3ffa4fb chore(angularjs): Do not use .component('foo', new Foo()) cc52bee chore(angularjs): Remove all 'ngInject'; in favor of explicit DI annotation b6bab1e chore(prettier): Just Use Prettier™ f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points e1b6663 fix(eslint): Fix eslint warnings for @typescript-eslint/no-use-before-define ddbe208 fix(eslint): Fix eslint warnings for no-useless-escape a35088a chore(webpack): Switch to TerserPlugin. Split bundles into ~5mb chunks 5c49dd2 chore(typescript): Switch module from 'commonjs' to 'esnext' to emit raw dynamic 'import()' 0451046 chore(package): Add .npmignore to all packages 6f608a0 fix(*): Remove all self closing tags in AngularJS templates Reference: angular/angular.js#1953 (comment) 93f1209 fix(appengine/google/kubernetes): change logo background colors to official brand colors (#6347) 86baac9 refactor(*): use mask-image CSS for cloud provider logos (#6280) 8cef885 fix(appengine): move artifact account dropdown below radio buttons (#6255) 6b8188b chore(*): Add core alias to module tsconfigs c190c41 fix(appengine): the selectedProvider is received as null when Create Server Group btn clicked (#5908) 351d4fb feat(appengine): unflag container image url deployments (#5894) 0a6d3f9 feat(provider/appengine): enable artifacts as config files (#5888) bdca8aa feat(appengine): move config template into html file (#5870)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Twinned with Clouddriver PR spinnaker/clouddriver#3453
Exposes a checkbox to let the user suppress the sequence number normally added to a server group when deployed:
And has a tooltip that explains how very not-normal it is to use this checkbox: