fix(core/pipeline): Fix revert button regression for templated pipelines #7427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When pressing the revert button for a templated pipeline, the original pipeline got merged with the rendered pipeline, resulting in a strange frankenstein pipeline that you couldn't save.
|
Regression in #7318 |
|
@spinnakerbot cherry-pick 1.16 |
spinnakerbot
pushed a commit
that referenced
this pull request
Sep 24, 2019
|
Cherry pick successful: #7429 |
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Sep 24, 2019
91e4c42 fix(tasks): (re)-enable durations on canceled tasks (spinnaker#7433) 4d3454c fix(core/pipeline): migrate more manual execution field layouts 15de4a8 fix(core/forms): MapEditorInput: Add validation for empty keys and empty values. Remove `errors` prop in favor of using `validation.validationMessage` which is passed from FormField/FormikFormField 70dee3f fix(core/pipeline): Don't break templated pipelines when updating config (spinnaker#7428) b942b5b fix(core/pipeline): Fix revert button regression for templated pipelines (spinnaker#7427) d7490f9 feat(core): rerun child pipelines with artifacts (spinnaker#7422)
christopherthielen
added a commit
that referenced
this pull request
Sep 24, 2019
91e4c42 fix(tasks): (re)-enable durations on canceled tasks (#7433) 4d3454c fix(core/pipeline): migrate more manual execution field layouts 15de4a8 fix(core/forms): MapEditorInput: Add validation for empty keys and empty values. Remove `errors` prop in favor of using `validation.validationMessage` which is passed from FormField/FormikFormField 70dee3f fix(core/pipeline): Don't break templated pipelines when updating config (#7428) b942b5b fix(core/pipeline): Fix revert button regression for templated pipelines (#7427) d7490f9 feat(core): rerun child pipelines with artifacts (#7422)
louisjimenez
pushed a commit
that referenced
this pull request
Sep 24, 2019
jervi
added a commit
to jervi/deck
that referenced
this pull request
Sep 26, 2019
I accidentally broke this in spinnaker#7427. Adding the removed line back, but only for non-templated pipelines.
louisjimenez
pushed a commit
that referenced
this pull request
Sep 26, 2019
) I accidentally broke this in #7427. Adding the removed line back, but only for non-templated pipelines.
spinnakerbot
pushed a commit
that referenced
this pull request
Sep 26, 2019
) I accidentally broke this in #7427. Adding the removed line back, but only for non-templated pipelines.
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
91e4c42 fix(tasks): (re)-enable durations on canceled tasks (spinnaker#7433) 4d3454c fix(core/pipeline): migrate more manual execution field layouts 15de4a8 fix(core/forms): MapEditorInput: Add validation for empty keys and empty values. Remove `errors` prop in favor of using `validation.validationMessage` which is passed from FormField/FormikFormField 70dee3f fix(core/pipeline): Don't break templated pipelines when updating config (spinnaker#7428) b942b5b fix(core/pipeline): Fix revert button regression for templated pipelines (spinnaker#7427) d7490f9 feat(core): rerun child pipelines with artifacts (spinnaker#7422)
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
…innaker#7440) I accidentally broke this in spinnaker#7427. Adding the removed line back, but only for non-templated pipelines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pressing the revert button for a templated pipeline, the original pipeline got merged with the rendered pipeline, resulting in a strange frankenstein pipeline that you couldn't save.