Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aws): added the ability to modify CPU credits #8736

Merged
merged 4 commits into from
Nov 19, 2020
Merged

feat(aws): added the ability to modify CPU credits #8736

merged 4 commits into from
Nov 19, 2020

Conversation

pdk27
Copy link
Contributor

@pdk27 pdk27 commented Nov 16, 2020

Summary

  • added a toggle for CPU credits with help fields (shown and related state is set only when applicable)
  • added reusable component for a toggle button group
  • added the ability to display toggle and reset conditionally
  • display CPU credits correctly in 'clone' wizard
  • read unlimitedCpuCredits correctly from source server group to prevent invalid configuration

Issue

The background information for the feature addition is detailed in spinnaker/spinnaker#5989

Screenshots and Gifs

Unlimited CPU Credits Help Field
ToggleGroupButtonInput

ToggleButtonGroupInputGif

Unlimited CPU credits is shown only when applicable and reset conditionally (i.e. when selected instance type doesn't support bursting)

ButtonStateMgmt_TypeAndProfileChange_Reset-part1

ButtonStateMgmt_TypeAndProfileChange_Reset-part2

Clone a SG, and unlimited CPU credits is populated from source SG

1. Launch templates enabled

  • Clone SG with standard cpu credits (Note: SG created with cpu credits undefined will default to false for applicable instance types in clouddriver)
  • Clone SG with unlimited cpu credits

Clone-displaysCreditsCorrectly

2. Launch templates disabled (Toggle is hidden and unset)

  • Clone SG

Clone-displaysCreditsCorrectly

  • Create SG

CreateSG_LTdisabled

Manual Tests

Tests

  1. Create Server Group (SG) with unlimited CPU credits turned on

  2. Create SG with unlimited CPU credits turned off

  3. Create SG with unlimited CPU credits untouched
    Result: SG created with unlimited CPU credits turned off, which is the default.
    unlimitedCpuCredits is set to undefined in Deck, which translates to false in clouddriver.
    See where default is set.

  4. unlimited CPU credits field is reset when instance type is changed in the wizard and the new type doesn't support bursting.

  5. Clone SG works as expected

  6. Clone SG + change unlimited CPU credits toggle / instance type works as expected

  7. Unlimited CPU credits toggle is displayed only when launch templates is enabled in Deck

@pdk27
feat(aws): added the ability to modify cpu credits
c49ed75 
  - added a toggle for cpu credits with help fields
  - added reusable component for a toggle
  - added the ability to display toggle and reset conditionally
  - display cpu credits correctly in 'clone' wizard

spinnaker/spinnaker#5989
@pdk27
Addressed PR feedback
48e733f 
 - added a separate setting for cpu credits
 - converted class components to functional components
 - other misc. feedback
@pdk27
PR feedback: added React hooks
5ff27d0
caseyhebebrand
caseyhebebrand approved these changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@caseyhebebrand caseyhebebrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for incorporating the feedback.

@caseyhebebrand caseyhebebrand merged commit 7a8f939 into spinnaker:master Nov 19, 2020
erikmunson pushed a commit that referenced this pull request Nov 24, 2020
chore(amazon): publish amazon@0.0.282
481ee92 
2ec9db0 fix(titus): Disable edits of step scaling dimensions (#8747)
7a8f939 feat(aws): added the ability to modify CPU credits (#8736)
erikmunson pushed a commit that referenced this pull request Nov 24, 2020
chore(core): publish core@0.0.533
3a8a1d1 
f4d7d14 feat(core/managed): surface pre-deployment steps for versions (#8750)
0cdf836 chore(core): Upload new illustrations (#8744)
e3c80c3 feat(core): Add a container for migration banners (#8735)
976e958 feat(bake): include git/repo artifacts in the list of artifacts to choose when baking helm charts (#8743)
7a8f939 feat(aws): added the ability to modify CPU credits (#8736)
@erikmunson erikmunson mentioned this pull request Nov 24, 2020
Merged
mergify bot pushed a commit that referenced this pull request Nov 24, 2020
@mergify
chore(amazon): publish amazon@0.0.282
e0e6efb 
2ec9db0 fix(titus): Disable edits of step scaling dimensions (#8747)
7a8f939 feat(aws): added the ability to modify CPU credits (#8736)
mergify bot pushed a commit that referenced this pull request Nov 24, 2020
@mergify
chore(core): publish core@0.0.533
fbb4e56 
f4d7d14 feat(core/managed): surface pre-deployment steps for versions (#8750)
0cdf836 chore(core): Upload new illustrations (#8744)
e3c80c3 feat(core): Add a container for migration banners (#8735)
976e958 feat(bake): include git/repo artifacts in the list of artifacts to choose when baking helm charts (#8743)
7a8f939 feat(aws): added the ability to modify CPU credits (#8736)
rumit-opsmx pushed a commit to rumit-opsmx/deck that referenced this pull request Nov 30, 2020
@siddhu-opsmx @pdk27
@dbyron0 @alanmquach @caseyhebebrand @mergify
feat(core/ManualJudgement): resolved merged conflict (#3)
28bc42e 
* feat(aws): added the ability to modify CPU credits (spinnaker#8736)

* feat(aws): added the ability to modify cpu credits

  - added a toggle for cpu credits with help fields
  - added reusable component for a toggle
  - added the ability to display toggle and reset conditionally
  - display cpu credits correctly in 'clone' wizard

spinnaker/spinnaker#5989

* Addressed PR feedback
 - added a separate setting for cpu credits
 - converted class components to functional components
 - other misc. feedback

* PR feedback: added React hooks

* Removed unused component

* feat(bake): include git/repo artifacts in the list of artifacts to choose when baking helm charts (spinnaker#8743)

now that spinnaker/rosco#740 is in

Co-authored-by: David Byron <david.byron@avast.com>

* fix(titus): Fallback dimensions for target tracking policy (spinnaker#8746)

* fix(titus): Disable edits of step scaling dimensions (spinnaker#8747)

* feat(core): Add a container for migration banners (spinnaker#8735)

* feat(core): Add migrations container component

* feat(core): Add container to routes eligible for migrations

feat(core): Add container to routes eligible for migrations

feat(core): Edit migration config type

feat(core): Edit migration config type

feat(core): Edit migration config type

fix(core): Update css

* Refactor and rename

Delete test banner

Delete test banner

* Update app/scripts/modules/core/src/banner/BannerContainer.tsx

* chore(core): Upload new illustrations (spinnaker#8744)

* feat(core/managed): surface pre-deployment steps for versions (spinnaker#8750)

* feat(core/presentation): add bake icon

* feat(core/domain): add lifecycle steps to managed artifact versions

* feat(core/managed): show status bubble for baking on versions

* feat(core/managed): surface baking on version detail pane

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* chore(amazon): publish amazon@0.0.282

2ec9db0 fix(titus): Disable edits of step scaling dimensions (spinnaker#8747)
7a8f939 feat(aws): added the ability to modify CPU credits (spinnaker#8736)

* chore(core): publish core@0.0.533

f4d7d14 feat(core/managed): surface pre-deployment steps for versions (spinnaker#8750)
0cdf836 chore(core): Upload new illustrations (spinnaker#8744)
e3c80c3 feat(core): Add a container for migration banners (spinnaker#8735)
976e958 feat(bake): include git/repo artifacts in the list of artifacts to choose when baking helm charts (spinnaker#8743)
7a8f939 feat(aws): added the ability to modify CPU credits (spinnaker#8736)

* chore(titus): publish titus@0.0.155

2ec9db0 fix(titus): Disable edits of step scaling dimensions (spinnaker#8747)
fadab40 fix(titus): Fallback dimensions for target tracking policy (spinnaker#8746)

* fix(core): Fix details drawer positioning (spinnaker#8754)

* chore(core): Export all generic instance components (spinnaker#8755)

* chore(core): publish core@0.0.534

f102966 chore(core): Export all generic instance components (spinnaker#8755)
530f59c fix(core): Fix details drawer positioning (spinnaker#8754)

* chore(pluginsdk-peerdeps): Publish 0.0.4 (spinnaker#8757)

Co-authored-by: Prathibha Datta Kumar <kprathib@amazon.com>
Co-authored-by: David Byron <dbyron@dbyron.com>
Co-authored-by: David Byron <david.byron@avast.com>
Co-authored-by: Alan Quach <aquach@netflix.com>
Co-authored-by: caseyhebebrand <caseyhebebrand@gmail.com>
Co-authored-by: Erik Munson <emunson@netflix.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: chebebrand <chebebrand@netflix.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caseyhebebrand caseyhebebrand caseyhebebrand approved these changes

Assignees
No one assigned
Labels
target-release/1.24
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pdk27 @caseyhebebrand @spinnakerbot