DRY Experiment#initialize #393
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experiment#set_alternatives_and_options appeared both in the
if
section and in the
else
section. I movedset_alternatives_and_options
out of the
if...else
block so that it is more DRY.I am not sure if setting only options[:alternatives] in the
else
clause is more readable than explicitly providing a hash with the attributes
to set as it happens in the
if
clause.