Skip to content

Conversation

pakallis
Copy link
Contributor

@pakallis pakallis commented May 11, 2016

Experiment#set_alternatives_and_options appeared both in the if
section and in the else section. I moved set_alternatives_and_options
out of the if...else block so that it is more DRY.

I am not sure if setting only options[:alternatives] in the else
clause is more readable than explicitly providing a hash with the attributes
to set as it happens in the if clause.

Experiment#set_alternatives_and_options appeared both in the `if`
section and in the `else` section. I moved `set_alternatives_and_options`
out of the `if...else` block so that it is more DRY.
I am not sure if setting only options[:alternatives] in the `else`
clause is more readable than explicitly providing a hash with the attributes
to set as it happens in the `if` clause.
@andrew
Copy link
Member

andrew commented May 12, 2016

I like it, thanks @pakallis 👍

@andrew andrew merged commit 340c5e7 into splitrb:master May 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants