Namespaced override param #398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/split/helper.rb
Outdated
| # frozen_string_literal: true | ||
| module Split | ||
| module Helper | ||
| AB_OVERRIDE_PARAM = "ab_test" |
There was a problem hiding this comment.
Named it this way because I thought this module was imported into user code, but it seems that doesn't happen directly, so maybe "AB_" could be stripped.
There was a problem hiding this comment.
Yeah I think we can drop the AB_
|
Looking good, will merge this when ready to release 2.0.0 |
Verified that both Rails and Sinatra parse [] in params to nested hashes this way.
|
@andrew Cool! Just force-pushed (for a cleaner log) removal of the AB_ constant prefix. |
|
Shipped in v2.0.0: https://github.com/splitrb/split/releases/tag/v2.0.0 |
divineforest
pushed a commit
to procommerz/split
that referenced
this pull request
Oct 14, 2016
Verified that both Rails and Sinatra parse [] in params to nested hashes this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #381.
Verified that both Rails and Sinatra parse [] in params to nested hashes this way.
Per #396, maybe "split_test" would be a better namespace?