feat: introduce 4 new methods for the CredentialManager and deprecate some old ones #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemrys
added a commit
to splunk/addonfactory-ucc-library
that referenced
this pull request
Aug 29, 2022
…words Similar to splunk/addonfactory-solutions-library-python#189. This change should fix the situation when you try to get a specific password for you add-on and some other password in other add-on is corrupted, then the configuration page is not loading for all the add-ons.
hetangmodi-crest
previously approved these changes
Aug 31, 2022
artemrys
force-pushed
the
fix/get-password-only-for-specific-realm
branch
from
485ea0a to
688a75d
Compare
artemrys
changed the title
artemrys
force-pushed
the
fix/get-password-only-for-specific-realm
branch
2 times, most recently
from
f1c1d21 to
13a36c4
Compare
Codecov Report
@@ Coverage Diff @@
## main #189 +/- ##
==========================================
- Coverage 84.09% 74.54% -9.55%
==========================================
Files 23 23
Lines 1848 1882 +34
==========================================
- Hits 1554 1403 -151
- Misses 294 479 +185
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
… some old ones This commit introduces 4 new methods for the CredentialManager: get_raw_passwords, get_raw_passwords_in_realm, get_clear_passwords, get_clear_passwords_in_realm which now should be used to access passwords through CredentialManager. Some old methods like _get_all_passwords_in_realm and _get_all_passwords were deprecated.
artemrys
force-pushed
the
fix/get-password-only-for-specific-realm
branch
from
13a36c4 to
e2a4330
Compare
Contributor
|
🎉 This PR is included in version 4.7.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces 4 new methods for the CredentialManager: get_raw_passwords, get_raw_passwords_in_realm, get_clear_passwords, get_clear_passwords_in_realm which now should be used to access passwords through CredentialManager.
Some old methods like _get_all_passwords_in_realm and _get_all_passwords were deprecated.