feat: merge develop into main #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marge main to develop
**Issue number:[ADDON-68670](https://splunk.atlassian.net/browse/ADDON-68670)** ## Summary Extending log module with new error logging functions. Breaking change for `log_exception` function. ### Changes * added new functions for error logging. * added `exc_l` parameter to logging message to categorize errors. * added `exc_l` parameter to `log_exception` function as a mandatory argument to log errors with custom category. ### User experience * user can categorize errors in the add-on using new functions. For now 5 basic categories are prepered: Authentication, Permission, Connection, Configuration, Server. * user can add custom error category using `log_exception` function by adding another args `exc_label` * all user's current use of the `log_exception` function must be extended with a `exc_label` argument to categorize error. ## Checklist If your change doesn't seem to apply, please leave them unchecked. * [x] I have performed a self-review of this change * [x] Changes have been tested * [] Changes are documented * [x] PR title follows [conventional commit semantics](https://www.conventionalcommits.org/en/v1.0.0/)
sgoral-splunk
changed the title
artemrys
approved these changes
Jun 12, 2024
Contributor
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: add logging function for basic error types